Updating status message on pressing 'reset all to default'

The old message "reset complete" will be replaced with "Reset acknowledged". The old message could have been interpreted
as the changes were already applied, when they will be applied only after restart.

Also, the message was announced on page load. This PR will fix that.

Bug: 997353
Change-Id: I090eb15c71e8af0bfc442327d5bbda5ebb4600e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769676Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#690979}

chrome/browser/ui/webui/flags_ui.cc

@@ -140,7 +140,8 @@ void FlagsUI::AddFlagsStrings(content::WebUIDataSource* source) {
                              IDS_FLAGS_UI_PAGE_WARNING_EXPLANATION);
   source->AddLocalizedString("relaunch", IDS_FLAGS_UI_RELAUNCH);
   source->AddLocalizedString("reset", IDS_FLAGS_UI_PAGE_RESET);
-  source->AddLocalizedString("reset-complete", IDS_FLAGS_UI_RESET_COMPLETE);
+  source->AddLocalizedString("reset-acknowledged",
+                             IDS_FLAGS_UI_RESET_ACKNOWLEDGED);
   source->AddLocalizedString("search-placeholder",
                              IDS_FLAGS_UI_SEARCH_PLACEHOLDER);
   source->AddLocalizedString("title", IDS_FLAGS_UI_TITLE);
@@ -169,8 +170,8 @@ void FlagsEnterpriseUI::AddEnterpriseStrings(content::WebUIDataSource* source) {
                              IDS_ENTERPRISE_SETTINGS_PAGE_WARNING_EXPLANATION);
   source->AddLocalizedString("relaunch", IDS_ENTERPRISE_SETTINGS_RELAUNCH);
   source->AddLocalizedString("reset", IDS_ENTERPRISE_SETTINGS_PAGE_RESET);
-  source->AddLocalizedString("reset-complete",
-                             IDS_ENTERPRISE_UI_RESET_COMPLETE);
+  source->AddLocalizedString("reset-acknowledged",
+                             IDS_ENTERPRISE_UI_RESET_ACKNOWLEDGED);
   source->AddLocalizedString("search-placeholder",
                              IDS_ENTERPRISE_SETTINGS_SEARCH_PLACEHOLDER);
   source->AddLocalizedString("title", IDS_ENTERPRISE_SETTINGS_TITLE);

components/flags_strings.grdp

@@ -54,8 +54,8 @@
   <message name="IDS_FLAGS_UI_CLEAR_SEARCH" translateable="false" desc="Tooltip for icon button that clears the searchbar on the chrome://flags page.">
     Clear search
   </message>
-  <message name="IDS_FLAGS_UI_RESET_COMPLETE" translateable="false" desc="Screen reader text stating that the reset action was completed.">
-    Reset complete
+  <message name="IDS_FLAGS_UI_RESET_ACKNOWLEDGED" translateable="false" desc="Screen reader text stating that the reset action was acknowledged.">
+    Reset acknowledged.
   </message>
   <message name="IDS_FLAGS_UI_EXPERIMENT_ENABLED" translateable="false" desc="Screen reader text stating that an experiment is enabled.">
     Experiment enabled
@@ -112,8 +112,8 @@
   <message name="IDS_ENTERPRISE_UI_CLEAR_SEARCH" desc="Tooltip for icon button that clears the searchbar on the chrome://flags/enterprise page.">
     Clear search
   </message>
-  <message name="IDS_ENTERPRISE_UI_RESET_COMPLETE" desc="Screen reader text stating that the reset action was completed.">
-    Reset complete
+  <message name="IDS_ENTERPRISE_UI_RESET_ACKNOWLEDGED" desc="Screen reader text stating that the reset action was acknowledged.">
+    Reset acknowledged.
   </message>
   <message name="IDS_ENTERPRISE_UI_EXPERIMENT_ENABLED" desc="Screen reader text stating that an experiment is enabled.">
     Experiment enabled

components/flags_ui/resources/flags.html

@@ -43,8 +43,9 @@
       <button id="experiment-reset-all" type="button" tabindex="3">
           $i18n{reset}
       </button>
-      <div class="screen-reader-only" id="reset-all-success-message"
-           role="status">$i18n{reset-complete}</div>
+      <div class="screen-reader-only" id="reset-all-success-message" role="status" aria-disabled="true">
+        $i18n{reset-acknowledged}
+      </div>
     </div>
   </div>
 </div>

components/flags_ui/resources/flags.js

@@ -169,6 +169,7 @@ function restartBrowser() {
 /** Reset all flags to their default values and refresh the UI. */
 function resetAllFlags() {
   chrome.send('resetAllFlags');
+  $('reset-all-success-message').setAttribute("aria-disabled", "false");
   // Updating the message in order for it to get announced by screen readers.
   $('reset-all-success-message').innerHTML += "!";
   showRestartToast(true);

ios/chrome/browser/ui/webui/flags_ui.cc

@@ -226,7 +226,8 @@ void FlagsUI::AddFlagsIOSStrings(web::WebUIIOSDataSource* source) {
                              IDS_FLAGS_UI_PAGE_WARNING_EXPLANATION);
   source->AddLocalizedString("relaunch", IDS_FLAGS_UI_RELAUNCH);
   source->AddLocalizedString("reset", IDS_FLAGS_UI_PAGE_RESET);
-  source->AddLocalizedString("reset-complete", IDS_FLAGS_UI_RESET_COMPLETE);
+  source->AddLocalizedString("reset-acknowledged",
+                             IDS_FLAGS_UI_RESET_ACKNOWLEDGED);
   source->AddLocalizedString("search-placeholder",
                              IDS_FLAGS_UI_SEARCH_PLACEHOLDER);
   source->AddLocalizedString("title", IDS_FLAGS_UI_TITLE);