GWP-ASan: Remove inline constructor

There is no longer a purpose for this constructor to be constexpr and
hence it does not need to be defined inline.

Bug: 896019
Change-Id: I69d37c8286d883ac7c83a76b79fafe7e5782da96
Reviewed-on: https://chromium-review.googlesource.com/c/1439927
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Vitaly Buka <vitalybuka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626742}

components/gwp_asan/common/allocator_state.cc

@@ -16,6 +16,8 @@ namespace internal {
 constexpr size_t AllocatorState::kGpaMaxPages;
 constexpr size_t AllocatorState::kMaxStackFrames;
 
+AllocatorState::AllocatorState() {}
+
 AllocatorState::GetMetadataReturnType AllocatorState::GetMetadataForAddress(
     uintptr_t exception_address,
     uintptr_t* slot_address) const {

components/gwp_asan/common/allocator_state.h

@@ -77,9 +77,7 @@ class AllocatorState {
     AllocationInfo dealloc;
   };
 
-  // TODO(vtsyrklevich): Get rid of inline (requires chromium-style plugin
-  // update.)
-  inline constexpr AllocatorState();
+  AllocatorState();
 
   // Returns true if address is in memory managed by this class.
   inline bool PointerIsMine(uintptr_t addr) const {
@@ -139,8 +137,6 @@ class AllocatorState {
   DISALLOW_COPY_AND_ASSIGN(AllocatorState);
 };
 
-constexpr AllocatorState::AllocatorState() {}
-
 // Ensure that the allocator state is a plain-old-data. That way we can safely
 // initialize it by copying memory from out-of-process without worrying about
 // destructors operating on the fields in an unexpected way.