Commit 7db45830 authored by Gyuyoung Kim's avatar Gyuyoung Kim Committed by Commit Bot

Convert AssociatedBinding to AssociatedReceiver in MediaServiceTest

Clean up old Mojo types in MediaServiceTest.

  - Convert mojo::AssociatedBinding to mojo::AssociatedReceiver
  - Convert mojo::FooClientAssociatedPtrInfo to mojo::PendingAssociatedRemote<>

Bug: 955171
Change-Id: Iff82fd44b8faa4775115e360889ada3b49facf1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883467
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Reviewed-by: default avatarKen Rockot <rockot@google.com>
Reviewed-by: default avatarChrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#710160}
parent a3cc20e8
...@@ -30,7 +30,8 @@ ...@@ -30,7 +30,8 @@
#include "media/mojo/mojom/renderer.mojom.h" #include "media/mojo/mojom/renderer.mojom.h"
#include "media/mojo/services/media_interface_provider.h" #include "media/mojo/services/media_interface_provider.h"
#include "media/mojo/services/media_manifest.h" #include "media/mojo/services/media_manifest.h"
#include "mojo/public/cpp/bindings/associated_binding.h" #include "mojo/public/cpp/bindings/associated_receiver.h"
#include "mojo/public/cpp/bindings/pending_associated_receiver.h"
#include "mojo/public/cpp/bindings/pending_remote.h" #include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/remote.h" #include "mojo/public/cpp/bindings/remote.h"
#include "services/service_manager/public/cpp/manifest_builder.h" #include "services/service_manager/public/cpp/manifest_builder.h"
...@@ -148,8 +149,8 @@ class MediaServiceTest : public testing::Test { ...@@ -148,8 +149,8 @@ class MediaServiceTest : public testing::Test {
.Build()}), .Build()}),
test_service_( test_service_(
test_service_manager_.RegisterTestInstance(kTestServiceName)), test_service_manager_.RegisterTestInstance(kTestServiceName)),
cdm_proxy_client_binding_(&cdm_proxy_client_), cdm_proxy_client_receiver_(&cdm_proxy_client_),
renderer_client_binding_(&renderer_client_), renderer_client_receiver_(&renderer_client_),
video_stream_(DemuxerStream::VIDEO) {} video_stream_(DemuxerStream::VIDEO) {}
~MediaServiceTest() override = default; ~MediaServiceTest() override = default;
...@@ -212,14 +213,15 @@ class MediaServiceTest : public testing::Test { ...@@ -212,14 +213,15 @@ class MediaServiceTest : public testing::Test {
interface_factory_->CreateCdmProxy(cdm_guid, interface_factory_->CreateCdmProxy(cdm_guid,
cdm_proxy_.BindNewPipeAndPassReceiver()); cdm_proxy_.BindNewPipeAndPassReceiver());
mojom::CdmProxyClientAssociatedPtrInfo client_ptr_info; mojo::PendingAssociatedRemote<mojom::CdmProxyClient> client_remote;
cdm_proxy_client_binding_.Bind(mojo::MakeRequest(&client_ptr_info)); cdm_proxy_client_receiver_.Bind(
client_remote.InitWithNewEndpointAndPassReceiver());
int cdm_id = CdmContext::kInvalidCdmId; int cdm_id = CdmContext::kInvalidCdmId;
EXPECT_CALL(*this, OnCdmProxyInitialized(CdmProxy::Status::kOk, _, _, _)) EXPECT_CALL(*this, OnCdmProxyInitialized(CdmProxy::Status::kOk, _, _, _))
.WillOnce(DoAll(SaveArg<3>(&cdm_id), QuitLoop(&run_loop))); .WillOnce(DoAll(SaveArg<3>(&cdm_id), QuitLoop(&run_loop)));
cdm_proxy_->Initialize( cdm_proxy_->Initialize(
std::move(client_ptr_info), std::move(client_remote),
base::BindOnce(&MediaServiceTest::OnCdmProxyInitialized, base::BindOnce(&MediaServiceTest::OnCdmProxyInitialized,
base::Unretained(this))); base::Unretained(this)));
run_loop.Run(); run_loop.Run();
...@@ -263,8 +265,9 @@ class MediaServiceTest : public testing::Test { ...@@ -263,8 +265,9 @@ class MediaServiceTest : public testing::Test {
mojo_video_stream_.reset(new MojoDemuxerStreamImpl( mojo_video_stream_.reset(new MojoDemuxerStreamImpl(
&video_stream_, MakeRequest(&video_stream_proxy_info))); &video_stream_, MakeRequest(&video_stream_proxy_info)));
mojom::RendererClientAssociatedPtrInfo client_ptr_info; mojo::PendingAssociatedRemote<mojom::RendererClient> client_remote;
renderer_client_binding_.Bind(mojo::MakeRequest(&client_ptr_info)); renderer_client_receiver_.Bind(
client_remote.InitWithNewEndpointAndPassReceiver());
std::vector<mojom::DemuxerStreamPtrInfo> streams; std::vector<mojom::DemuxerStreamPtrInfo> streams;
streams.push_back(std::move(video_stream_proxy_info)); streams.push_back(std::move(video_stream_proxy_info));
...@@ -272,7 +275,7 @@ class MediaServiceTest : public testing::Test { ...@@ -272,7 +275,7 @@ class MediaServiceTest : public testing::Test {
EXPECT_CALL(*this, OnRendererInitialized(expected_result)) EXPECT_CALL(*this, OnRendererInitialized(expected_result))
.WillOnce(QuitLoop(&run_loop)); .WillOnce(QuitLoop(&run_loop));
renderer_->Initialize( renderer_->Initialize(
std::move(client_ptr_info), std::move(streams), nullptr, std::move(client_remote), std::move(streams), nullptr,
base::BindOnce(&MediaServiceTest::OnRendererInitialized, base::BindOnce(&MediaServiceTest::OnRendererInitialized,
base::Unretained(this))); base::Unretained(this)));
run_loop.Run(); run_loop.Run();
...@@ -292,10 +295,10 @@ class MediaServiceTest : public testing::Test { ...@@ -292,10 +295,10 @@ class MediaServiceTest : public testing::Test {
mojo::Remote<mojom::Renderer> renderer_; mojo::Remote<mojom::Renderer> renderer_;
NiceMock<MockCdmProxyClient> cdm_proxy_client_; NiceMock<MockCdmProxyClient> cdm_proxy_client_;
mojo::AssociatedBinding<mojom::CdmProxyClient> cdm_proxy_client_binding_; mojo::AssociatedReceiver<mojom::CdmProxyClient> cdm_proxy_client_receiver_;
NiceMock<MockRendererClient> renderer_client_; NiceMock<MockRendererClient> renderer_client_;
mojo::AssociatedBinding<mojom::RendererClient> renderer_client_binding_; mojo::AssociatedReceiver<mojom::RendererClient> renderer_client_receiver_;
StrictMock<MockDemuxerStream> video_stream_; StrictMock<MockDemuxerStream> video_stream_;
std::unique_ptr<MojoDemuxerStreamImpl> mojo_video_stream_; std::unique_ptr<MojoDemuxerStreamImpl> mojo_video_stream_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment