Commit 7ddf616a authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

Simplify startup metrics collection on Mac.

[NSScreen screensHaveSeparateSpaces] is available on MacOS 10.9 and
above [1], so selector checking is no longer necessary.

[1] https://developer.apple.com/documentation/appkit/nsscreen/1388365-screenshaveseparatespaces

Change-Id: I713baf8c10cd0efb510002211aea66b6bb379f99
Reviewed-on: https://chromium-review.googlesource.com/1163214Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581000}
parent 4dbdf1e5
......@@ -11,7 +11,7 @@ namespace {
// The possible values of the setting "Screens Have Separate Spaces".
enum ScreenSpacesConfiguration {
SCREENS_CANNOT_HAVE_SEPARATE_SPACES = 0,
SCREENS_CANNOT_HAVE_SEPARATE_SPACES_DEPRECATED = 0,
SCREENS_HAVE_SEPARATE_SPACES = 1,
SCREENS_HAVE_SHARED_SPACES = 2,
SCREEN_SPACES_CONFIGURATION_COUNT = 3
......@@ -21,14 +21,8 @@ enum ScreenSpacesConfiguration {
void ChromeBrowserMainExtraPartsMetrics::RecordMacMetrics() {
ScreenSpacesConfiguration separate_spaces =
SCREENS_CANNOT_HAVE_SEPARATE_SPACES;
if ([NSScreen respondsToSelector:@selector(screensHaveSeparateSpaces)]) {
BOOL screens_have_separate_spaces = [NSScreen screensHaveSeparateSpaces];
separate_spaces = screens_have_separate_spaces
? SCREENS_HAVE_SEPARATE_SPACES
: SCREENS_HAVE_SHARED_SPACES;
}
[NSScreen screensHaveSeparateSpaces] ? SCREENS_HAVE_SEPARATE_SPACES
: SCREENS_HAVE_SHARED_SPACES;
UMA_HISTOGRAM_ENUMERATION("OSX.Settings.ScreensHaveSeparateSpaces",
separate_spaces,
SCREEN_SPACES_CONFIGURATION_COUNT);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment