2011-03-14 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block. Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html https://bugs.webkit.org/show_bug.cgi?id=56202 By testing for geolocation watch errors, the test tests more than it should, which can cause a flaky result as demonstrated by https://bugs.webkit.org/show_bug.cgi?id=56126 . * fast/dom/Geolocation/resources/window-close-popup.html: * fast/dom/Geolocation/script-tests/window-close-crash.js: git-svn-id: svn://svn.chromium.org/blink/trunk@81014 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2011-03-14 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block. Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html https://bugs.webkit.org/show_bug.cgi?id=56202 By testing for geolocation watch errors, the test tests more than it should, which can cause a flaky result as demonstrated by https://bugs.webkit.org/show_bug.cgi?id=56126 . * fast/dom/Geolocation/resources/window-close-popup.html: * fast/dom/Geolocation/script-tests/window-close-crash.js: git-svn-id: svn://svn.chromium.org/blink/trunk@81014 bbb929c8-8fbe-4397-9dbb-9b2b20218538
7de57c01 · jknotten@chromium.org · d8b21927 · 7de57c01 · 7de57c01 · 7de57c01
Commit 7de57c01 authored Mar 14, 2011 by jknotten@chromium.org
3 changed files
--- a/third_party/WebKit/LayoutTests/ChangeLog
+++ b/third_party/WebKit/LayoutTests/ChangeLog
+2011-03-14  John Knottenbelt  <jknotten@chromium.org>
+
+        Reviewed by Steve Block.
+
+        Fix flaky layout test: fast/dom/Geolocation/window-close-crash.html
+        https://bugs.webkit.org/show_bug.cgi?id=56202
+
+        By testing for geolocation watch errors, the test tests more than
+        it should, which can cause a flaky result as demonstrated by
+        https://bugs.webkit.org/show_bug.cgi?id=56126 .
+
+        * fast/dom/Geolocation/resources/window-close-popup.html:
+        * fast/dom/Geolocation/script-tests/window-close-crash.js:
+
 2011-03-14  Alejandro G. Castro  <alex@igalia.com>

        Update more expectations after r80857.
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/resources/window-close-popup.html
@@ -11,9 +11,7 @@ function loadNext() {
       layoutTestController.setMockGeolocationPosition(mockLatitude, mockLongitude, mockAccuracy);
    }

-    navigator.geolocation.watchPosition(
-       function(p) { window.opener.gotPosition(); },
-       function(e) { window.opener.failedToCreateWatch(e); });
+    navigator.geolocation.watchPosition(window.opener.gotPosition);
 }
 </script>
 <body onload="loadNext()"></body>
--- a/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/window-close-crash.js
+++ b/third_party/WebKit/LayoutTests/fast/dom/Geolocation/script-tests/window-close-crash.js
@@ -28,12 +28,6 @@ function waitForWindowToClose()
    finishJSTest();
 }

-function failedToCreateWatch(e)
-{
-    testFailed("Failed to create watch: " + e);
-    finishJSTest();
-}
-
 debug("Main page opening resources/window-close-popup.html");
 otherWindow = window.open("resources/window-close-popup.html");