Set flag to not wait for activation

Waiting for the compositor "activation" means that we cannot
parallelize the layers. Create an experiment here to remove it.

Tests and perf with this WIP CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2057346

Bug: 1046463
Change-Id: I7631a84eca45e2ce20de51628c8c652108ba6cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056933
Commit-Queue: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#743161}

cc/base/features.cc

@@ -12,6 +12,11 @@ namespace features {
 const base::Feature kImpulseScrollAnimations = {
     "ImpulseScrollAnimations", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// When enabled BeginMainFrame does not wait for activation in the compositor
+// thread for texture layers (crbug.com/1046463)
+const base::Feature kTextureLayerSkipWaitForActivation{
+    "TextureLayerSkipWaitForActivation", base::FEATURE_DISABLED_BY_DEFAULT};
+
 #if !defined(OS_ANDROID)
 // Enables latency recovery on the impl thread.
 const base::Feature kImplLatencyRecovery = {"ImplLatencyRecovery",

cc/base/features.h

@@ -12,6 +12,7 @@
 namespace features {
 
 CC_BASE_EXPORT extern const base::Feature kImpulseScrollAnimations;
+CC_BASE_EXPORT extern const base::Feature kTextureLayerSkipWaitForActivation;
 
 #if !defined(OS_ANDROID)
 CC_BASE_EXPORT extern const base::Feature kImplLatencyRecovery;

cc/layers/texture_layer.cc

@@ -10,6 +10,7 @@
 #include "base/sequenced_task_runner.h"
 #include "base/synchronization/lock.h"
 #include "base/trace_event/trace_event.h"
+#include "cc/base/features.h"
 #include "cc/base/simple_enclosed_region.h"
 #include "cc/layers/texture_layer_client.h"
 #include "cc/layers/texture_layer_impl.h"
@@ -111,7 +112,9 @@ void TextureLayer::SetTransferableResourceInternal(
   UpdateDrawsContent(HasDrawableContent());
   // The active frame needs to be replaced and the mailbox returned before the
   // commit is called complete.
-  SetNextCommitWaitsForActivation();
+  if (!base::FeatureList::IsEnabled(
+          features::kTextureLayerSkipWaitForActivation))
+    SetNextCommitWaitsForActivation();
 }
 
 void TextureLayer::SetTransferableResource(
@@ -139,10 +142,12 @@ void TextureLayer::SetLayerTreeHost(LayerTreeHost* host) {
     needs_set_resource_ = true;
     // The active frame needs to be replaced and the mailbox returned before the
     // commit is called complete.
-    SetNextCommitWaitsForActivation();
+    if (!base::FeatureList::IsEnabled(
+            features::kTextureLayerSkipWaitForActivation))
+      SetNextCommitWaitsForActivation();
   }
   if (host) {
-    // When attached to a new LayerTreHost, all previously registered
+    // When attached to a new LayerTreeHost, all previously registered
     // SharedBitmapIds will need to be re-sent to the new TextureLayerImpl
     // representing this layer on the compositor thread.
     to_register_bitmaps_.insert(

chrome/browser/about_flags.cc

@@ -4730,6 +4730,10 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kImpulseScrollAnimationsName,
      flag_descriptions::kImpulseScrollAnimationsDescription, kOsAll,
      FEATURE_VALUE_TYPE(features::kImpulseScrollAnimations)},
+    {"texture-layer-skip-wait-for-activation",
+     flag_descriptions::kTextureLayerSkipWaitForActivationName,
+     flag_descriptions::kTextureLayerSkipWaitForActivationDescription, kOsAll,
+     FEATURE_VALUE_TYPE(features::kTextureLayerSkipWaitForActivation)},
     {"percent-based-scrolling", flag_descriptions::kPercentBasedScrollingName,
      flag_descriptions::kPercentBasedScrollingDescription, kOsAll,
      FEATURE_VALUE_TYPE(features::kPercentBasedScrolling)},

chrome/browser/flag-metadata.json

@@ -3525,6 +3525,11 @@
     "owners": [ "joelhockey", "benwells", "//chrome/browser/chromeos/guest_os/OWNERS" ],
     "expiry_milestone": 85
   },
+  {
+    "name": "texture-layer-skip-wait-for-activation",
+    "owners": [ "fserb@chromium.org", "aaronhk@chromium.org" ],
+    "expiry_milestone": 90
+  },
   {
     "name": "tint-gl-composited-content",
     "owners": [ "chromeos-gfx@google.com" ],

chrome/browser/flag_descriptions.cc

@@ -1189,6 +1189,10 @@ const char kNewTabstripAnimationName[] = "New tabstrip animations";
 const char kNewTabstripAnimationDescription[] =
     "New implementation of tabstrip animations.";
 
+const char kTextureLayerSkipWaitForActivationName[] = "Parallelize layers";
+const char kTextureLayerSkipWaitForActivationDescription[] =
+    "Don't wait for layer activation before beginning new frame.";
+
 const char kNotificationIndicatorName[] = "Notification Indicators";
 const char kNotificationIndicatorDescription[] =
     "Enable notification indicators, which appear on app icons when a "

chrome/browser/flag_descriptions.h

@@ -711,6 +711,9 @@ extern const char kNewUsbBackendDescription[];
 extern const char kNewTabstripAnimationName[];
 extern const char kNewTabstripAnimationDescription[];
 
+extern const char kTextureLayerSkipWaitForActivationName[];
+extern const char kTextureLayerSkipWaitForActivationDescription[];
+
 extern const char kNotificationIndicatorName[];
 extern const char kNotificationIndicatorDescription[];
 

tools/metrics/histograms/enums.xml

@@ -38928,6 +38928,7 @@ from previous Chrome versions.
   <int value="301869874" label="NTPPhysicalWebPageSuggestions:disabled"/>
   <int value="303058039" label="AccountConsistency:disabled"/>
   <int value="303252119" label="AutofillExpandedPopupViews:disabled"/>
+  <int value="304588364" label="TextureLayerSkipWaitForActivation:enabled"/>
   <int value="304901781" label="NewUsbBackend:enabled"/>
   <int value="306641800" label="AndroidSiteSettingsUIRefresh:disabled"/>
   <int value="306834044" label="webui-tab-strip"/>
@@ -39045,6 +39046,7 @@ from previous Chrome versions.
   <int value="423855924" label="enable-tab-switcher-theme-colors"/>
   <int value="425072496" label="GridLayoutForNtpShortcuts:enabled"/>
   <int value="425520856" label="InterestFeedNotifications:enabled"/>
+  <int value="430776375" label="TextureLayerSkipWaitForActivation:disabled"/>
   <int value="430959979" label="SyncStandaloneTransport:disabled"/>
   <int value="431691805" label="MediaDocumentDownloadButton:enabled"/>
   <int value="434033638" label="PwaPersistentNotification:disabled"/>