Commit 7e2581e4 authored by Quinten Yearsley's avatar Quinten Yearsley Committed by Commit Bot

Disable cpplint Tricium analyzer in chromium/src.

When cpplint was enabled, there was discussion about its usefulness
since clang-format is already enforced via presubmit checks.

It was decided that cpplint could be somewhat useful until a
clang-tidy analyzer was enabled, and at that point clang-tidy may
cover any use-cases that were covered by cpplint (and many more).

Now, clang-tidy is here and enabled, and cpplint should be disabled
as it sometimes produces false positives.

Bug: 1048144
Change-Id: I79be2b1660b186e16925be791f26b14c4e63f0a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071358Reviewed-by: default avatarBen Pastene <bpastene@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744129}
parent 5ab2898a
...@@ -69,19 +69,6 @@ selections { ...@@ -69,19 +69,6 @@ selections {
platform: LINUX platform: LINUX
} }
selections {
function: "Cpplint"
platform: UBUNTU
configs {
name: "filter"
value: "-,+readability/todo,+readability/check,+readability/fn_size,+build/header_guard,+build/include_order"
}
configs {
name: "verbose"
value: "4"
}
}
selections { selections {
function: "GitFileIsolator" function: "GitFileIsolator"
platform: UBUNTU platform: UBUNTU
......
...@@ -69,19 +69,6 @@ selections { ...@@ -69,19 +69,6 @@ selections {
platform: LINUX platform: LINUX
} }
selections {
function: "Cpplint"
platform: UBUNTU
configs {
name: "filter"
value: "-,+readability/todo,+readability/check,+readability/fn_size,+build/header_guard,+build/include_order"
}
configs {
name: "verbose"
value: "4"
}
}
selections { selections {
function: "GitFileIsolator" function: "GitFileIsolator"
platform: UBUNTU platform: UBUNTU
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment