Commit 7e2c66d4 authored by oshima@chromium.org's avatar oshima@chromium.org

ChromeOS: Add more logs to troubleshoot plugin issues in chromeos login screen.

This is addition to http://codereview.chromium.org/9477021/

BUG=chromium-os:26646
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9584026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124762 0039d316-1c4b-4281-b951-d872f2087c98
parent d49185be
...@@ -495,6 +495,11 @@ PluginModule::~PluginModule() { ...@@ -495,6 +495,11 @@ PluginModule::~PluginModule() {
} }
bool PluginModule::InitAsInternalPlugin(const EntryPoints& entry_points) { bool PluginModule::InitAsInternalPlugin(const EntryPoints& entry_points) {
#if defined(OS_CHROMEOS)
// TODO(oshima): Remove this once crosbug.com/26646 is resolved.
LOG(ERROR) << "#### PluginModule::InitAsInternalPlugin name=" << name_;
#endif // defined (OS_CHROMEOS)
if (InitializeModule(entry_points)) { if (InitializeModule(entry_points)) {
entry_points_ = entry_points; entry_points_ = entry_points;
return true; return true;
...@@ -503,7 +508,17 @@ bool PluginModule::InitAsInternalPlugin(const EntryPoints& entry_points) { ...@@ -503,7 +508,17 @@ bool PluginModule::InitAsInternalPlugin(const EntryPoints& entry_points) {
} }
bool PluginModule::InitAsLibrary(const FilePath& path) { bool PluginModule::InitAsLibrary(const FilePath& path) {
#if defined(OS_CHROMEOS)
// TODO(oshima): Remove this once crosbug.com/26646 is resolved.
LOG(ERROR) << "#### PluginModule::InitAsLibrary name=" << name_;
#endif // defined (OS_CHROMEOS)
base::NativeLibrary library = base::LoadNativeLibrary(path, NULL); base::NativeLibrary library = base::LoadNativeLibrary(path, NULL);
#if defined(OS_CHROMEOS)
// TODO(oshima): Remove this once crosbug.com/26646 is resolved.
LOG(ERROR) << "#### PluginModule::InitAsLibrary loaded";
#endif // defined (OS_CHROMEOS)
if (!library) if (!library)
return false; return false;
...@@ -521,6 +536,11 @@ bool PluginModule::InitAsLibrary(const FilePath& path) { ...@@ -521,6 +536,11 @@ bool PluginModule::InitAsLibrary(const FilePath& path) {
void PluginModule::InitAsProxied( void PluginModule::InitAsProxied(
PluginDelegate::OutOfProcessProxy* out_of_process_proxy) { PluginDelegate::OutOfProcessProxy* out_of_process_proxy) {
#if defined(OS_CHROMEOS)
// TODO(oshima): Remove this once crosbug.com/26646 is resolved.
LOG(ERROR) << "#### PluginModule::InitAsProxied name=" << name_;
#endif // defined (OS_CHROMEOS)
DCHECK(!out_of_process_proxy_.get()); DCHECK(!out_of_process_proxy_.get());
out_of_process_proxy_.reset(out_of_process_proxy); out_of_process_proxy_.reset(out_of_process_proxy);
} }
...@@ -621,6 +641,11 @@ bool PluginModule::InitializeModule(const EntryPoints& entry_points) { ...@@ -621,6 +641,11 @@ bool PluginModule::InitializeModule(const EntryPoints& entry_points) {
DCHECK(!out_of_process_proxy_.get()) << "Don't call for proxied modules."; DCHECK(!out_of_process_proxy_.get()) << "Don't call for proxied modules.";
DCHECK(entry_points.initialize_module != NULL); DCHECK(entry_points.initialize_module != NULL);
int retval = entry_points.initialize_module(pp_module(), &GetInterface); int retval = entry_points.initialize_module(pp_module(), &GetInterface);
#if defined(OS_CHROMEOS)
// TODO(oshima): Remove this once crosbug.com/26646 is resolved.
LOG(ERROR) << "#### PluginModule::InitModule result=" << retval;
#endif // defined (OS_CHROMEOS)
if (retval != 0) { if (retval != 0) {
LOG(WARNING) << "PPP_InitializeModule returned failure " << retval; LOG(WARNING) << "PPP_InitializeModule returned failure " << retval;
return false; return false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment