customtabs: report the correct value for a UMA histogram.

CustomTabs.DetachedResourceRequest.FinalStatus enum contains labels for
-net::ERR_*, not the direct value. This causes reporting in UMA to be
incorrectly labeled.

Bug: 816837, 851399
Change-Id: I7febe0ec98f9ae7b028f36af9ff4a40cc938191d
Reviewed-on: https://chromium-review.googlesource.com/1095178Reviewed-by: Alexandr Ilin <alexilin@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565982}

chrome/browser/android/customtabs/detached_resource_request.cc

@@ -4,6 +4,7 @@
 
 #include "chrome/browser/android/customtabs/detached_resource_request.h"
 
+#include <cstdlib>
 #include <utility>
 
 #include "base/location.h"
@@ -147,7 +148,7 @@ void DetachedResourceRequest::OnResponseCallback(
   }
 
   base::UmaHistogramSparse("CustomTabs.DetachedResourceRequest.FinalStatus",
-                           net_error);
+                           std::abs(net_error));
   std::move(cb_).Run(success);
 }
 

chrome/browser/android/customtabs/detached_resource_request_unittest.cc

@@ -292,7 +292,7 @@ TEST_F(DetachedResourceRequestTest, SimpleFailure) {
   histogram_tester.ExpectTotalCount(
       "CustomTabs.DetachedResourceRequest.Duration.Failure", 1);
   histogram_tester.ExpectBucketCount(
-      "CustomTabs.DetachedResourceRequest.FinalStatus", net::ERR_FAILED, 1);
+      "CustomTabs.DetachedResourceRequest.FinalStatus", -net::ERR_FAILED, 1);
 }
 
 TEST_F(DetachedResourceRequestTest, MultipleRequests) {
@@ -511,7 +511,7 @@ TEST_F(DetachedResourceRequestTest, TooManyRedirects) {
       "CustomTabs.DetachedResourceRequest.RedirectsCount.Failure", 20, 1);
   histogram_tester.ExpectBucketCount(
       "CustomTabs.DetachedResourceRequest.FinalStatus",
-      net::ERR_TOO_MANY_REDIRECTS, 1);
+      -net::ERR_TOO_MANY_REDIRECTS, 1);
 }
 
 TEST_F(DetachedResourceRequestTest, CachedResponse) {