Add documents and some nits for sharing icon view.

Bug: 988461
Change-Id: I820bca05f073ef379178d7cf17fbbb7efbaba4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764131Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#689956}

chrome/browser/ui/views/sharing/sharing_icon_view.cc

@@ -68,7 +68,7 @@ bool SharingIconView::Update() {
 
   const bool is_bubble_showing = IsBubbleShowing();
 
-  if (is_bubble_showing || isLoadingAnimationVisible() ||
+  if (is_bubble_showing || IsLoadingAnimationVisible() ||
       last_controller_ != controller) {
     ResetSlideAnimation(/*show=*/false);
   }
@@ -76,7 +76,7 @@ bool SharingIconView::Update() {
   last_controller_ = controller;
 
   const bool is_visible =
-      is_bubble_showing || isLoadingAnimationVisible() || label()->GetVisible();
+      is_bubble_showing || IsLoadingAnimationVisible() || label()->GetVisible();
   const bool visibility_changed = GetVisible() != is_visible;
 
   SetVisible(is_visible);
@@ -193,6 +193,6 @@ const gfx::VectorIcon& SharingIconView::GetVectorIconBadge() const {
 void SharingIconView::OnExecuting(
     PageActionIconView::ExecuteSource execute_source) {}
 
-bool SharingIconView::isLoadingAnimationVisible() {
+bool SharingIconView::IsLoadingAnimationVisible() {
   return loading_animation_.get();
 }

chrome/browser/ui/views/sharing/sharing_icon_view.h

@@ -44,12 +44,15 @@ class SharingIconView : public PageActionIconView {
   void UpdateInkDrop(bool activate);
   void UpdateOpacity();
   void UpdateLoaderColor();
-  bool isLoadingAnimationVisible();
+  bool IsLoadingAnimationVisible();
   bool should_show_error() { return should_show_error_; }
   void set_should_show_error(bool should_show_error) {
     should_show_error_ = should_show_error;
   }
+
+  // Get the supporting controller for this icon view.
   virtual SharingUiController* GetController() const = 0;
+  // Return the success delivery message Id.
   virtual base::Optional<int> GetSuccessMessageId() const = 0;
 
  private: