Commit 7e7e8538 authored by Yann Dago's avatar Yann Dago Committed by Commit Bot

FlagsUI: update heading and warning text

Visual: http://screen/ihJM5xoT5BL

Bug: 1009457
Change-Id: Ide05aa692968a6956a8e364a722d8e705a9193fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829571Reviewed-by: default avatarHector Carmona <hcarmona@chromium.org>
Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703751}
parent ee1a599b
...@@ -128,6 +128,7 @@ void FlagsUI::AddStrings(content::WebUIDataSource* source) { ...@@ -128,6 +128,7 @@ void FlagsUI::AddStrings(content::WebUIDataSource* source) {
source->AddLocalizedString("enabled", IDS_FLAGS_UI_ENABLED_FEATURE); source->AddLocalizedString("enabled", IDS_FLAGS_UI_ENABLED_FEATURE);
source->AddLocalizedString("experiment-enabled", source->AddLocalizedString("experiment-enabled",
IDS_FLAGS_UI_EXPERIMENT_ENABLED); IDS_FLAGS_UI_EXPERIMENT_ENABLED);
source->AddLocalizedString("heading", IDS_FLAGS_UI_TITLE);
source->AddLocalizedString("no-results", IDS_FLAGS_UI_NO_RESULTS); source->AddLocalizedString("no-results", IDS_FLAGS_UI_NO_RESULTS);
source->AddLocalizedString("not-available-platform", source->AddLocalizedString("not-available-platform",
IDS_FLAGS_UI_NOT_AVAILABLE_ON_PLATFORM); IDS_FLAGS_UI_NOT_AVAILABLE_ON_PLATFORM);
...@@ -161,11 +162,11 @@ void FlagsDeprecatedUI::AddStrings(content::WebUIDataSource* source) { ...@@ -161,11 +162,11 @@ void FlagsDeprecatedUI::AddStrings(content::WebUIDataSource* source) {
IDS_DEPRECATED_FEATURES_ENABLED_FEATURE); IDS_DEPRECATED_FEATURES_ENABLED_FEATURE);
source->AddLocalizedString("experiment-enabled", source->AddLocalizedString("experiment-enabled",
IDS_DEPRECATED_UI_EXPERIMENT_ENABLED); IDS_DEPRECATED_UI_EXPERIMENT_ENABLED);
source->AddLocalizedString("heading", IDS_DEPRECATED_FEATURES_HEADING);
source->AddLocalizedString("no-results", IDS_DEPRECATED_FEATURES_NO_RESULTS); source->AddLocalizedString("no-results", IDS_DEPRECATED_FEATURES_NO_RESULTS);
source->AddLocalizedString("not-available-platform", source->AddLocalizedString("not-available-platform",
IDS_DEPRECATED_FEATURES_NOT_AVAILABLE_ON_PLATFORM); IDS_DEPRECATED_FEATURES_NOT_AVAILABLE_ON_PLATFORM);
source->AddLocalizedString("page-warning", source->AddString("page-warning", std::string());
IDS_DEPRECATED_FEATURES_PAGE_WARNING);
source->AddLocalizedString("page-warning-explanation", source->AddLocalizedString("page-warning-explanation",
IDS_DEPRECATED_FEATURES_PAGE_WARNING_EXPLANATION); IDS_DEPRECATED_FEATURES_PAGE_WARNING_EXPLANATION);
source->AddLocalizedString("relaunch", IDS_DEPRECATED_FEATURES_RELAUNCH); source->AddLocalizedString("relaunch", IDS_DEPRECATED_FEATURES_RELAUNCH);
......
...@@ -111,12 +111,11 @@ ...@@ -111,12 +111,11 @@
<message name="IDS_DEPRECATED_FEATURES_TITLE" desc="The page title for the about:enterprise-settings page."> <message name="IDS_DEPRECATED_FEATURES_TITLE" desc="The page title for the about:enterprise-settings page.">
Deprecated Features Deprecated Features
</message> </message>
<message name="IDS_DEPRECATED_FEATURES_PAGE_WARNING" desc="A warning stating that the features of the page are experimental."> <message name="IDS_DEPRECATED_FEATURES_HEADING" translateable="false" desc="The page heading for the about:flags page.">
Warning: Deprecated features ahead! Unsupported features
</message> </message>
<message name="IDS_DEPRECATED_FEATURES_PAGE_WARNING_EXPLANATION" desc="Warning to users that features are deprecated. Shown prominently at the top of the page."> <message name="IDS_DEPRECATED_FEATURES_PAGE_WARNING_EXPLANATION" desc="Warning to users that features are deprecated. Shown prominently at the top of the page.">
By enabling these features, you will be using deprecated features These features are disabled by default. They will not be available in future versions of Chrome.
that will disappear in future versions.
</message> </message>
<message name="IDS_DEPRECATED_FEATURES_NO_RESULTS" desc="Message shown when searching and no results were found."> <message name="IDS_DEPRECATED_FEATURES_NO_RESULTS" desc="Message shown when searching and no results were found.">
No matching features No matching features
......
...@@ -45,7 +45,7 @@ ...@@ -45,7 +45,7 @@
<div id="body-container" style="visibility:hidden"> <div id="body-container" style="visibility:hidden">
<div id="flagsTemplate"> <div id="flagsTemplate">
<div class="flex-container"> <div class="flex-container">
<div class="flex"><h1 class="section-header-title">$i18n{title}</h1></div> <div class="flex"><h1 class="section-header-title">$i18n{heading}</h1></div>
<span id="version" class="flex">$i18n{version}</span> <span id="version" class="flex">$i18n{version}</span>
</div> </div>
<div class="blurb-container"> <div class="blurb-container">
......
...@@ -218,6 +218,7 @@ void FlagsUI::AddFlagsIOSStrings(web::WebUIIOSDataSource* source) { ...@@ -218,6 +218,7 @@ void FlagsUI::AddFlagsIOSStrings(web::WebUIIOSDataSource* source) {
source->AddLocalizedString("enabled", IDS_FLAGS_UI_ENABLED_FEATURE); source->AddLocalizedString("enabled", IDS_FLAGS_UI_ENABLED_FEATURE);
source->AddLocalizedString("experiment-enabled", source->AddLocalizedString("experiment-enabled",
IDS_FLAGS_UI_EXPERIMENT_ENABLED); IDS_FLAGS_UI_EXPERIMENT_ENABLED);
source->AddLocalizedString("heading", IDS_FLAGS_UI_TITLE);
source->AddLocalizedString("no-results", IDS_FLAGS_UI_NO_RESULTS); source->AddLocalizedString("no-results", IDS_FLAGS_UI_NO_RESULTS);
source->AddLocalizedString("not-available-platform", source->AddLocalizedString("not-available-platform",
IDS_FLAGS_UI_NOT_AVAILABLE_ON_PLATFORM); IDS_FLAGS_UI_NOT_AVAILABLE_ON_PLATFORM);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment