Polish the start surface toolbar scrolling.
In this CL, we do two changes: 1. Add a start surface check in ToolbarManager#ToolbarNtpDelegate#isLocationBarShown. Before[1], this returns true even if it's in start surface v2 homepage, that causes the ToolbarPhone[2] set background color transparent[3]. [1] Demo: https://drive.google.com/file/d/1dPJwI4lK-9ch5Wwnx06oY9IIXenLIGzr/view?usp=sharing [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;drc=5b8933e94139a0ab5be46141666fdfcce0f624f6;l=2366 [3] https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarPhone.java;drc=5b8933e94139a0ab5be46141666fdfcce0f624f6;l=712 2. Add a shrink animation for omnibox when it's about to be scrolled up and toolbar container is showing. Please see demo (The left one is the fixed one): https://drive.google.com/file/d/1jRfYGx9lD3UfxaTabhaNe9Cs_YWTJt2J/view?usp=sharing Bug: 1113852, 1136595 Change-Id: I549223c7a8b7c2e2f56ab62e0d0a090e1185fc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517544 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:Filip Gorski <fgorski@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827029}
Showing
Please register or sign in to comment