Commit 7e90d5a5 authored by Noel Gordon's avatar Noel Gordon Committed by Commit Bot

[filesapp] Create DevToolsListenerBrowserTest tmp_dir_ when used

Only CollectCodeCoverage() needs tmp_dir_ so create it there (when the
browser test is collecting code coverage).

Tbr: benreich
Bug: 1113941
Change-Id: Ib92b271ec76f8c6f42f4f704467bc00cbf3b688a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483984Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818342}
parent 8dd6d740
...@@ -33,9 +33,6 @@ class DevToolsListenerBrowserTest : public content::DevToolsAgentHostObserver, ...@@ -33,9 +33,6 @@ class DevToolsListenerBrowserTest : public content::DevToolsAgentHostObserver,
void SetUpOnMainThread() override { void SetUpOnMainThread() override {
process_id_ = base::GetUniqueIdForProcess().GetUnsafeValue(); process_id_ = base::GetUniqueIdForProcess().GetUnsafeValue();
content::DevToolsAgentHost::AddObserver(this); content::DevToolsAgentHost::AddObserver(this);
base::ScopedAllowBlockingForTesting allow_blocking;
CHECK(tmp_dir_.CreateUniqueTempDir());
} }
bool ShouldForceDevToolsAgentHostCreation() override { return true; } bool ShouldForceDevToolsAgentHostCreation() override { return true; }
...@@ -65,6 +62,7 @@ class DevToolsListenerBrowserTest : public content::DevToolsAgentHostObserver, ...@@ -65,6 +62,7 @@ class DevToolsListenerBrowserTest : public content::DevToolsAgentHostObserver,
void CollectCodeCoverage() { void CollectCodeCoverage() {
base::ScopedAllowBlockingForTesting allow_blocking; base::ScopedAllowBlockingForTesting allow_blocking;
CHECK(tmp_dir_.CreateUniqueTempDir());
base::FilePath coverage_store = base::FilePath coverage_store =
tmp_dir_.GetPath().AppendASCII("devtools_listener_browser_test"); tmp_dir_.GetPath().AppendASCII("devtools_listener_browser_test");
CHECK(base::CreateDirectory(coverage_store)); CHECK(base::CreateDirectory(coverage_store));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment