Commit 7eadc0fb authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Avoid explicit empty string initializations.

They already start out empty by default.

Change-Id: Iccfab99f6591753b91c08fbdc1d5edc13b1fa1c5
Reviewed-on: https://chromium-review.googlesource.com/c/1335280Reviewed-by: default avatarDavid Jacobo <djacobo@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608221}
parent aa6cb1f1
...@@ -58,7 +58,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest, ...@@ -58,7 +58,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest,
FindBarController* find_bar_controller = browser()->GetFindBarController(); FindBarController* find_bar_controller = browser()->GetFindBarController();
ASSERT_NE(nullptr, find_bar_controller); ASSERT_NE(nullptr, find_bar_controller);
base::string16 empty_string(base::ASCIIToUTF16("")); const base::string16 empty_string;
find_bar_controller->SetText(empty_string); find_bar_controller->SetText(empty_string);
chrome::Find(browser()); chrome::Find(browser());
...@@ -90,7 +90,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest, ...@@ -90,7 +90,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest,
browser_incognito->GetFindBarController(); browser_incognito->GetFindBarController();
ASSERT_NE(nullptr, find_bar_controller); ASSERT_NE(nullptr, find_bar_controller);
base::string16 empty_string(base::ASCIIToUTF16("")); const base::string16 empty_string;
find_bar_controller->SetText(empty_string); find_bar_controller->SetText(empty_string);
chrome::Find(browser_incognito); chrome::Find(browser_incognito);
...@@ -130,7 +130,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest, ...@@ -130,7 +130,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest,
GURL url = GetURL(kSimple); GURL url = GetURL(kSimple);
ui_test_utils::NavigateToURL(browser(), url); ui_test_utils::NavigateToURL(browser(), url);
base::string16 empty_string(base::ASCIIToUTF16("")); const base::string16 empty_string;
find_bar_controller->SetText(empty_string); find_bar_controller->SetText(empty_string);
chrome::Find(browser()); chrome::Find(browser());
...@@ -221,7 +221,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest, ...@@ -221,7 +221,7 @@ IN_PROC_BROWSER_TEST_F(FindBarPlatformHelperMacInteractiveUITest,
content::WebContents* first_active_web_contents = content::WebContents* first_active_web_contents =
browser()->tab_strip_model()->GetActiveWebContents(); browser()->tab_strip_model()->GetActiveWebContents();
base::string16 empty_string(base::ASCIIToUTF16("")); const base::string16 empty_string;
find_bar_controller->SetText(empty_string); find_bar_controller->SetText(empty_string);
chrome::Find(browser()); chrome::Find(browser());
......
...@@ -461,7 +461,7 @@ TEST_F(ArcIntentHelperTest, TestAppendStringToIntentHelperPackageName) { ...@@ -461,7 +461,7 @@ TEST_F(ArcIntentHelperTest, TestAppendStringToIntentHelperPackageName) {
fake_activity), fake_activity),
package_name + "." + fake_activity); package_name + "." + fake_activity);
std::string empty_string = ""; const std::string empty_string;
EXPECT_EQ(ArcIntentHelperBridge::AppendStringToIntentHelperPackageName( EXPECT_EQ(ArcIntentHelperBridge::AppendStringToIntentHelperPackageName(
empty_string), empty_string),
package_name + "."); package_name + ".");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment