Commit 7ec7e5ae authored by John Z Wu's avatar John Z Wu Committed by Commit Bot

Fix flaky autofill tests in //ios/web_view.

These tests were flaky because submitting a form causes a navigation
on top of loading the test page. These two navigations happening at the
same time can cause some race conditions ending in a DCHECK.

By directing the form to 'about:blank', it avoids the extra navigation.

Bug: 834660,842122
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If535a18fdc277d0c6766967cdbeea2f85fa415dc
Reviewed-on: https://chromium-review.googlesource.com/1056411
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558335}
parent d3f427f7
...@@ -33,7 +33,8 @@ NSString* const kTestFieldValue = @"FieldValue"; ...@@ -33,7 +33,8 @@ NSString* const kTestFieldValue = @"FieldValue";
NSString* const kTestSubmitID = @"SubmitID"; NSString* const kTestSubmitID = @"SubmitID";
NSString* const kTestFormHtml = NSString* const kTestFormHtml =
[NSString stringWithFormat: [NSString stringWithFormat:
@"<form name='%@' id='%@'>" // Direct form to about:blank to avoid unnecessary navigation.
@"<form action='about:blank' name='%@' id='%@'>"
"<input type='text' name='%@' id='%@'/>" "<input type='text' name='%@' id='%@'/>"
"<input type='submit' id='%@'/>" "<input type='submit' id='%@'/>"
"</form>", "</form>",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment