Rename PageActionIconView::Refresh() to Update()

This CL renames PageActionIconView::Refresh() to be Update().
This makes it more consistent with
PageActionIconContainer::UpdatePageActionIcon() and LocationBar methods
like UpdateSaveCreditCardIcon().

There are no behavioural changes in this CL.

Bug: 788051
Change-Id: I1d5d05cfc659d89a41480771e2415b261553263b
Reviewed-on: https://chromium-review.googlesource.com/1082064Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565135}

chrome/browser/ui/views/autofill/save_card_icon_view.cc

@@ -39,7 +39,7 @@ views::BubbleDialogDelegateView* SaveCardIconView::GetBubble() const {
       controller->save_card_bubble_view());
 }
 
-bool SaveCardIconView::Refresh() {
+bool SaveCardIconView::Update() {
   if (!GetWebContents())
     return false;
 

chrome/browser/ui/views/autofill/save_card_icon_view.h

@@ -27,7 +27,7 @@ class SaveCardIconView : public PageActionIconView {
 
   // PageActionIconView:
   views::BubbleDialogDelegateView* GetBubble() const override;
-  bool Refresh() override;
+  bool Update() override;
   base::string16 GetTextForTooltipAndAccessibleName() const override;
 
  protected:

chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -856,7 +856,7 @@ bool LocationBarView::RefreshPageActionIconViews() {
 
   bool visibility_changed = false;
   for (auto* v : page_action_icons_) {
-    visibility_changed |= v->Refresh();
+    visibility_changed |= v->Update();
   }
   return visibility_changed;
 }
@@ -867,7 +867,8 @@ bool LocationBarView::RefreshZoomView() {
   if (!web_contents)
     return false;
   const bool was_visible = zoom_view_->visible();
-  zoom_view_->Update(zoom::ZoomController::FromWebContents(web_contents));
+  zoom_view_->UpdateWithController(
+      zoom::ZoomController::FromWebContents(web_contents));
   return was_visible != zoom_view_->visible();
 }
 
@@ -1029,14 +1030,14 @@ void LocationBarView::UpdateContentSettingsIcons() {
 }
 
 void LocationBarView::UpdateManagePasswordsIconAndBubble() {
-  if (manage_passwords_icon_view_->Refresh()) {
+  if (manage_passwords_icon_view_->Update()) {
     Layout();
     SchedulePaint();
   }
 }
 
 void LocationBarView::UpdateSaveCreditCardIcon() {
-  if (save_credit_card_icon_view_->Refresh()) {
+  if (save_credit_card_icon_view_->Update()) {
     Layout();
     SchedulePaint();
   }

chrome/browser/ui/views/location_bar/zoom_view.cc

@@ -21,13 +21,13 @@ ZoomView::ZoomView(LocationBarView::Delegate* location_bar_delegate,
     : PageActionIconView(nullptr, 0, delegate),
       location_bar_delegate_(location_bar_delegate),
       icon_(&kZoomMinusIcon) {
-  Update(nullptr);
+  UpdateWithController(nullptr);
 }
 
 ZoomView::~ZoomView() {
 }
 
-void ZoomView::Update(zoom::ZoomController* zoom_controller) {
+void ZoomView::UpdateWithController(zoom::ZoomController* zoom_controller) {
   if (!zoom_controller ||
       (!ZoomBubbleView::GetZoomBubble() &&
        zoom_controller->IsAtDefaultZoom()) ||

chrome/browser/ui/views/location_bar/zoom_view.h

@@ -26,7 +26,7 @@ class ZoomView : public PageActionIconView {
 
   // Updates the image and its tooltip appropriately, hiding or showing the icon
   // as needed.
-  void Update(zoom::ZoomController* zoom_controller);
+  void UpdateWithController(zoom::ZoomController* zoom_controller);
 
  protected:
   // PageActionIconView:

chrome/browser/ui/views/page_action/page_action_icon_view.cc

@@ -87,7 +87,7 @@ void PageActionIconView::OnBubbleWidgetCreated(views::Widget* bubble_widget) {
     SetHighlighted(true);
 }
 
-bool PageActionIconView::Refresh() {
+bool PageActionIconView::Update() {
   return false;
 }
 

chrome/browser/ui/views/page_action/page_action_icon_view.h

@@ -52,7 +52,7 @@ class PageActionIconView : public views::InkDropHostView {
 
   // Updates the icon state and associated bubble when the WebContents changes.
   // Returns true if there was a change.
-  virtual bool Refresh();
+  virtual bool Update();
 
  protected:
   enum ExecuteSource {

chrome/browser/ui/views/passwords/manage_passwords_icon_views.cc

@@ -58,7 +58,7 @@ views::BubbleDialogDelegateView* ManagePasswordsIconViews::GetBubble() const {
   return PasswordBubbleViewBase::manage_password_bubble();
 }
 
-bool ManagePasswordsIconViews::Refresh() {
+bool ManagePasswordsIconViews::Update() {
   if (!GetWebContents())
     return false;
 

chrome/browser/ui/views/passwords/manage_passwords_icon_views.h

@@ -27,7 +27,7 @@ class ManagePasswordsIconViews : public ManagePasswordsIconView,
 
   // PageActionIconView:
   views::BubbleDialogDelegateView* GetBubble() const override;
-  bool Refresh() override;
+  bool Update() override;
   void OnExecuting(PageActionIconView::ExecuteSource source) override;
   bool OnMousePressed(const ui::MouseEvent& event) override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;

chrome/browser/ui/views/translate/translate_icon_view.cc

@@ -31,7 +31,7 @@ views::BubbleDialogDelegateView* TranslateIconView::GetBubble() const {
   return TranslateBubbleView::GetCurrentBubble();
 }
 
-bool TranslateIconView::Refresh() {
+bool TranslateIconView::Update() {
   if (!GetWebContents())
     return false;
 

chrome/browser/ui/views/translate/translate_icon_view.h

@@ -20,7 +20,7 @@ class TranslateIconView : public PageActionIconView {
 
   // PageActionIconView:
   views::BubbleDialogDelegateView* GetBubble() const override;
-  bool Refresh() override;
+  bool Update() override;
 
  protected:
   // PageActionIconView: