Commit 7ee07083 authored by Christian Dullweber's avatar Christian Dullweber Committed by Commit Bot

Cleanup CookiePolicyBrowserTest

We don't need to enable the kImprovedCookieControls flag anymore to
make these tests pass.

Bug: 967668
Change-Id: Ic0858e9b48756fbd644a0d506c674df87e1e1dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859779
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705866}
parent ad253ec8
...@@ -143,20 +143,6 @@ class CookiePolicyBrowserTest : public InProcessBrowserTest { ...@@ -143,20 +143,6 @@ class CookiePolicyBrowserTest : public InProcessBrowserTest {
DISALLOW_COPY_AND_ASSIGN(CookiePolicyBrowserTest); DISALLOW_COPY_AND_ASSIGN(CookiePolicyBrowserTest);
}; };
// CookiePolicyBrowserTest with a feature list that enables usage of
// TopLevelOrigin for CookieSettings. This is only required until this
// behavior can be enabled by default. https://crbug.com/988398
class CookiePolicyTopLevelOriginBrowserTest : public CookiePolicyBrowserTest {
public:
CookiePolicyTopLevelOriginBrowserTest() {
enable_cookie_controls_.InitAndEnableFeature(
content_settings::kImprovedCookieControls);
}
private:
base::test::ScopedFeatureList enable_cookie_controls_;
};
// Visits a page that sets a first-party cookie. // Visits a page that sets a first-party cookie.
IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, AllowFirstPartyCookies) { IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, AllowFirstPartyCookies) {
SetBlockThirdPartyCookies(false); SetBlockThirdPartyCookies(false);
...@@ -317,7 +303,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, ...@@ -317,7 +303,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest,
ExpectNestedFrameContent("None"); ExpectNestedFrameContent("None");
} }
IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest,
ThirdPartyCookiesIFrameExceptions) { ThirdPartyCookiesIFrameExceptions) {
SetBlockThirdPartyCookies(true); SetBlockThirdPartyCookies(true);
...@@ -354,7 +340,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, ...@@ -354,7 +340,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest,
ExpectNestedFrameContent("thirdparty"); ExpectNestedFrameContent("thirdparty");
} }
IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest,
ThirdPartyCookiesIFrameThirdPartyExceptions) { ThirdPartyCookiesIFrameThirdPartyExceptions) {
SetBlockThirdPartyCookies(true); SetBlockThirdPartyCookies(true);
...@@ -392,8 +378,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, ...@@ -392,8 +378,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest,
ExpectNestedFrameContent("thirdparty"); ExpectNestedFrameContent("thirdparty");
} }
IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, ThirdPartyIFrameStorage) {
ThirdPartyIFrameStorage) {
NavigateToPageWithFrame("a.com"); NavigateToPageWithFrame("a.com");
NavigateFrameTo("b.com", "/browsing_data/site_data.html"); NavigateFrameTo("b.com", "/browsing_data/site_data.html");
ExpectStorageForFrame(GetFrame(), false); ExpectStorageForFrame(GetFrame(), false);
...@@ -434,8 +419,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, ...@@ -434,8 +419,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest,
ExpectStorageForFrame(GetFrame(), true); ExpectStorageForFrame(GetFrame(), true);
} }
IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, NestedThirdPartyIFrameStorage) {
NestedThirdPartyIFrameStorage) {
NavigateToPageWithFrame("a.com"); NavigateToPageWithFrame("a.com");
NavigateFrameTo("b.com", "/iframe.html"); NavigateFrameTo("b.com", "/iframe.html");
NavigateNestedFrameTo("c.com", "/browsing_data/site_data.html"); NavigateNestedFrameTo("c.com", "/browsing_data/site_data.html");
...@@ -482,8 +466,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, ...@@ -482,8 +466,7 @@ IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest,
ExpectStorageForFrame(GetNestedFrame(), true); ExpectStorageForFrame(GetNestedFrame(), true);
} }
IN_PROC_BROWSER_TEST_F(CookiePolicyTopLevelOriginBrowserTest, IN_PROC_BROWSER_TEST_F(CookiePolicyBrowserTest, NestedFirstPartyIFrameStorage) {
NestedFirstPartyIFrameStorage) {
NavigateToPageWithFrame("a.com"); NavigateToPageWithFrame("a.com");
NavigateFrameTo("b.com", "/iframe.html"); NavigateFrameTo("b.com", "/iframe.html");
NavigateNestedFrameTo("a.com", "/browsing_data/site_data.html"); NavigateNestedFrameTo("a.com", "/browsing_data/site_data.html");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment