Skip to content

GitLab

T
tangled
Commit 7ee731bc authored by Yoichi Osato's avatar Yoichi Osato Committed by Commit Bot
Browse files
Options

Remove editing/selection/5354455-2.html 

The test confirms right click on element should create a selection.
That was introduced 11 years ago:
https://chromium.googlesource.com/chromium/src/+/563113d2b16713e83a7507637a28973c8cf7db82

However, the feature was removed at some point and no platform expects that.
Currently the test only confirms right click on element doesn't create selection
unlike its description and right click behavior is tested at another tests well, e.g.
LayoutTests/editing/selection/context-menu-text-selection.html

Then this patch removes the test.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: 708452
Change-Id: I2886aeb05728df9f84bb10ee87e062362f1fd0ce
Reviewed-on: https://chromium-review.googlesource.com/1092552Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565936}
parent 16f38267
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 110 deletions
third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
View file @ 7ee731bc
......@@ -130,7 +130,6 @@ crbug.com/591099 editing/pasteboard/dragstart-contains-default-content.html [ Fa
crbug.com/591099 editing/selection/4776665.html [ Failure Pass ]
crbug.com/591099 editing/selection/4960137.html [ Failure ]
crbug.com/591099 editing/selection/5232159.html [ Failure ]
crbug.com/591099 editing/selection/5354455-2.html [ Failure ]
crbug.com/591099 editing/selection/continuations-with-move-caret-to-boundary.html [ Failure ]
crbug.com/591099 editing/selection/paint-hyphen.html [ Failure ]
crbug.com/591099 external/wpt/2dcontext/drawing-images-to-the-canvas/drawimage_html_image_11.html [ Pass ]
......
third_party/WebKit/LayoutTests/editing/selection/5354455-2.html deleted 100644 → 0
View file @ 16f38267
<html>
<head>
<style type="text/css">
#title h1 {
margin: 0px 24px 0px 0px;
padding: 23px 0px 0px 175px;
}
body {
position: absolute;
max-width: 600px;
padding: 5px;
border: 1px solid black;
}
</style>
</head>
<body>
<h1 id="title">Word selection on right click test</h1>
This tests to make sure that right clicking non-editable content only creates a word selection for clicks over text. <span id="word">To</span> run manually, right click on text, and a word should be selected. Right click on the empty space outside and to the right of the black border, the selection should be removed.
</body>
<script>
if (window.testRunner) {
// Make sure that right click is not a no-op (selects a word).
word = document.getElementById("word");
x = word.offsetParent.offsetLeft + word.offsetLeft + word.offsetWidth / 2;
y = word.offsetParent.offsetTop + word.offsetTop + word.offsetHeight / 2;
eventSender.mouseMoveTo(x, y);
eventSender.contextClick();
// This should not.
body = document.body;
x = body.offsetLeft + body.offsetWidth + 10;
y = body.offsetTop + body.offsetHeight - 10;
eventSender.mouseMoveTo(x, y);
eventSender.contextClick();
}
</script>
</html>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/5354455-2-expected.txt deleted 100644 → 0
View file @ 16f38267
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x600
LayoutBlockFlow {HTML} at (0,0) size 800x600
layer at (8,8) size 612x150
LayoutBlockFlow (positioned) {BODY} at (8,8) size 612x150.44 [border: (1px solid #000000)]
LayoutBlockFlow {H1} at (6,6) size 600x37
LayoutText {#text} at (0,0) size 449x36
text run at (0,0) width 449: "Word selection on right click test"
LayoutBlockFlow (anonymous) at (6,64.44) size 600x80
LayoutText {#text} at (0,0) size 597x39
text run at (0,0) width 597: "This tests to make sure that right clicking non-editable content only creates a word selection for"
text run at (0,20) width 103: "clicks over text. "
LayoutInline {SPAN} at (0,0) size 17x19
LayoutText {#text} at (103,20) size 17x19
text run at (103,20) width 17: "To"
LayoutText {#text} at (120,20) size 599x59
text run at (120,20) width 410: " run manually, right click on text, and a word should be selected. "
text run at (530,20) width 69: "Right click"
text run at (0,40) width 542: "on the empty space outside and to the right of the black border, the selection should be"
text run at (0,60) width 59: "removed."
caret: position 0 of child 0 {#text} of child 1 {H1} of body
third_party/WebKit/LayoutTests/platform/mac/editing/selection/5354455-2-expected.txt deleted 100644 → 0
View file @ 16f38267
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x600
LayoutBlockFlow {HTML} at (0,0) size 800x600
layer at (8,8) size 612x142
LayoutBlockFlow (positioned) {BODY} at (8,8) size 612x142.44 [border: (1px solid #000000)]
LayoutBlockFlow {H1} at (6,6) size 600x37
LayoutText {#text} at (0,0) size 449x37
text run at (0,0) width 449: "Word selection on right click test"
LayoutBlockFlow (anonymous) at (6,64.44) size 600x72
LayoutText {#text} at (0,0) size 590x36
text run at (0,0) width 590: "This tests to make sure that right clicking non-editable content only creates a word selection"
text run at (0,18) width 129: "for clicks over text. "
LayoutInline {SPAN} at (0,0) size 18x18
LayoutText {#text} at (128,18) size 18x18
text run at (128,18) width 18: "To"
LayoutText {#text} at (145,18) size 599x54
text run at (145,18) width 418: " run manually, right click on text, and a word should be selected. "
text run at (562,18) width 37: "Right"
text run at (0,36) width 589: "click on the empty space outside and to the right of the black border, the selection should be"
text run at (0,54) width 60: "removed."
caret: position 0 of child 0 {#text} of child 1 {H1} of body
third_party/WebKit/LayoutTests/platform/win/editing/selection/5354455-2-expected.txt deleted 100644 → 0
View file @ 16f38267
layer at (0,0) size 800x600
LayoutView at (0,0) size 800x600
layer at (0,0) size 800x600
LayoutBlockFlow {HTML} at (0,0) size 800x600
layer at (8,8) size 612x130
LayoutBlockFlow (positioned) {BODY} at (8,8) size 612x130.44 [border: (1px solid #000000)]
LayoutBlockFlow {H1} at (6,6) size 600x37
LayoutText {#text} at (0,0) size 448x36
text run at (0,0) width 448: "Word selection on right click test"
LayoutBlockFlow (anonymous) at (6,64.44) size 600x60
LayoutText {#text} at (0,0) size 570x39
text run at (0,0) width 570: "This tests to make sure that right clicking non-editable content only creates a word selection for"
text run at (0,20) width 99: "clicks over text. "
LayoutInline {SPAN} at (0,0) size 16x19
LayoutText {#text} at (99,20) size 16x19
text run at (99,20) width 16: "To"
LayoutText {#text} at (115,20) size 586x39
text run at (115,20) width 389: " run manually, right click on text, and a word should be selected. "
text run at (504,20) width 82: "Right click on"
text run at (0,40) width 563: "the empty space outside and to the right of the black border, the selection should be removed."
caret: position 0 of child 0 {#text} of child 1 {H1} of body
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment