Commit 7efdfe13 authored by Makoto Shimazu's avatar Makoto Shimazu Committed by Commit Bot

Disable flaky tests in RequestDesktopMobileSiteTestCase

These tests are disabled:
- RequestDesktopMobileSiteTestCase/testAppVersionJSAPIWithMobileUserAgent
- RequestDesktopMobileSiteTestCase/testRequestDesktopSiteKeptSessionRestoration
- RequestDesktopMobileSiteTestCase/testRequestDesktopSiteDoesNotPropagateToNewTab
- RequestDesktopMobileSiteTestCase/testRequestMobileSitePropagatesToNextNavigations
- RequestDesktopMobileSiteTestCase/testRequestDesktopSitePropagatesToNextNavigations
- RequestDesktopMobileSiteTestCase/testRequestDesktopSiteGoBackToMobilePurged

Tbr: gambard@chromium.org
No-Try: true
Bug: 1111194
Change-Id: I3ac977790b4eef149cd8ccbecf955d416043319f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331252Reviewed-by: default avatarMakoto Shimazu <shimazu@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#795790}
parent d8031b1f
...@@ -152,7 +152,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -152,7 +152,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that requesting desktop site of a page works and the user agent // Tests that requesting desktop site of a page works and the user agent
// propagates to the next navigations in the same tab. // propagates to the next navigations in the same tab.
- (void)testRequestDesktopSitePropagatesToNextNavigations { //
// Disabled due to flakiness: https://crbug.com/1111194.
- (void)DISABLED_testRequestDesktopSitePropagatesToNextNavigations {
std::unique_ptr<web::DataResponseProvider> provider( std::unique_ptr<web::DataResponseProvider> provider(
new UserAgentResponseProvider()); new UserAgentResponseProvider());
web::test::SetUpHttpServer(std::move(provider)); web::test::SetUpHttpServer(std::move(provider));
...@@ -174,7 +176,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -174,7 +176,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that requesting desktop site of a page works and the requested user // Tests that requesting desktop site of a page works and the requested user
// agent is kept when restoring the session. // agent is kept when restoring the session.
- (void)testRequestDesktopSiteKeptSessionRestoration { //
// Disabled due to flakiness: https://crbug.com/1111194.
- (void)DISABLED_testRequestDesktopSiteKeptSessionRestoration {
std::unique_ptr<web::DataResponseProvider> provider( std::unique_ptr<web::DataResponseProvider> provider(
new UserAgentResponseProvider()); new UserAgentResponseProvider());
web::test::SetUpHttpServer(std::move(provider)); web::test::SetUpHttpServer(std::move(provider));
...@@ -208,7 +212,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -208,7 +212,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that requesting desktop site of a page works and desktop user agent // Tests that requesting desktop site of a page works and desktop user agent
// does not propagate to next the new tab. // does not propagate to next the new tab.
- (void)testRequestDesktopSiteDoesNotPropagateToNewTab { //
// Disabled due to flakiness: https://crbug.com/1111194.
- (void)DISABLED_testRequestDesktopSiteDoesNotPropagateToNewTab {
std::unique_ptr<web::DataResponseProvider> provider( std::unique_ptr<web::DataResponseProvider> provider(
new UserAgentResponseProvider()); new UserAgentResponseProvider());
web::test::SetUpHttpServer(std::move(provider)); web::test::SetUpHttpServer(std::move(provider));
...@@ -255,7 +261,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -255,7 +261,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that when requesting desktop on another page and coming back to a page // Tests that when requesting desktop on another page and coming back to a page
// that has been purged from memory, we still display the mobile page. // that has been purged from memory, we still display the mobile page.
- (void)testRequestDesktopSiteGoBackToMobilePurged { //
// Disabled due to flakiness: https://crbug.com/1111194.
- (void)DISABLED_testRequestDesktopSiteGoBackToMobilePurged {
if (@available(iOS 13, *)) { if (@available(iOS 13, *)) {
} else { } else {
EARL_GREY_TEST_DISABLED(@"On iOS 12, the User Agent can be wrong when " EARL_GREY_TEST_DISABLED(@"On iOS 12, the User Agent can be wrong when "
...@@ -324,7 +332,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -324,7 +332,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that requesting mobile site of a page works and the user agent // Tests that requesting mobile site of a page works and the user agent
// propagates to the next navigations in the same tab. // propagates to the next navigations in the same tab.
- (void)testRequestMobileSitePropagatesToNextNavigations { //
// Disabled due to flakiness: https://crbug.com/1111194.
- (void)DISABLED_testRequestMobileSitePropagatesToNextNavigations {
std::unique_ptr<web::DataResponseProvider> provider( std::unique_ptr<web::DataResponseProvider> provider(
new UserAgentResponseProvider()); new UserAgentResponseProvider());
web::test::SetUpHttpServer(std::move(provider)); web::test::SetUpHttpServer(std::move(provider));
...@@ -402,7 +412,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider { ...@@ -402,7 +412,9 @@ class UserAgentResponseProvider : public web::DataResponseProvider {
// Tests that navigator.appVersion JavaScript API returns correct string for // Tests that navigator.appVersion JavaScript API returns correct string for
// mobile User Agent and the platform. // mobile User Agent and the platform.
- (void)testAppVersionJSAPIWithMobileUserAgent { //
// Disabled due to flakiness: https://crbug.com/1111194.
- (void)DISABLED_testAppVersionJSAPIWithMobileUserAgent {
web::test::SetUpFileBasedHttpServer(); web::test::SetUpFileBasedHttpServer();
[ChromeEarlGrey loadURL:web::test::HttpServer::MakeUrl(kUserAgentTestURL)]; [ChromeEarlGrey loadURL:web::test::HttpServer::MakeUrl(kUserAgentTestURL)];
// Verify initial reception of the mobile site. // Verify initial reception of the mobile site.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment