Commit 7f0839a9 authored by Kyle Horimoto's avatar Kyle Horimoto Committed by Commit Bot

[CrOS Settings] Fix "Google" searches

Previously, a query for "Google" would only show results related to the
Google Assistant. This CL downgrades the default ranking for several of
these search tags so that other Google-related content is surfaced.

Fixed: 1096809
Change-Id: I75c2ade1a5997742fa18840a2d81e5ca112ccf40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265438
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarRegan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782208}
parent 400c4bf9
......@@ -54,19 +54,19 @@ const std::vector<SearchConcept>& GetAssistantSearchConcepts() {
{IDS_OS_SETTINGS_TAG_ASSISTANT_PREFERRED_INPUT,
mojom::kAssistantSubpagePath,
mojom::SearchResultIcon::kAssistant,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultDefaultRank::kLow,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kAssistantVoiceInput}},
{IDS_OS_SETTINGS_TAG_ASSISTANT_NOTIFICATIONS,
mojom::kAssistantSubpagePath,
mojom::SearchResultIcon::kAssistant,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultDefaultRank::kLow,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kAssistantNotifications}},
{IDS_OS_SETTINGS_TAG_ASSISTANT_RELATED_INFO,
mojom::kAssistantSubpagePath,
mojom::SearchResultIcon::kAssistant,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultDefaultRank::kLow,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kAssistantRelatedInfo}},
});
......@@ -105,7 +105,7 @@ const std::vector<SearchConcept>& GetAssistantQuickAnswersSearchConcepts() {
{IDS_OS_SETTINGS_TAG_ASSISTANT_QUICK_ANSWERS,
mojom::kAssistantSubpagePath,
mojom::SearchResultIcon::kAssistant,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultDefaultRank::kLow,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kAssistantQuickAnswers}},
});
......@@ -117,7 +117,7 @@ const std::vector<SearchConcept>& GetAssistantHotwordDspSearchConcepts() {
{IDS_OS_SETTINGS_TAG_ASSISTANT_OK_GOOGLE,
mojom::kAssistantSubpagePath,
mojom::SearchResultIcon::kAssistant,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultDefaultRank::kLow,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kAssistantOkGoogle},
{IDS_OS_SETTINGS_TAG_ASSISTANT_OK_GOOGLE_ALT1,
......@@ -132,7 +132,7 @@ const std::vector<SearchConcept>& GetAssistantVoiceMatchSearchConcepts() {
{IDS_OS_SETTINGS_TAG_ASSISTANT_TRAIN_VOICE_MODEL,
mojom::kAssistantSubpagePath,
mojom::SearchResultIcon::kAssistant,
mojom::SearchResultDefaultRank::kMedium,
mojom::SearchResultDefaultRank::kLow,
mojom::SearchResultType::kSetting,
{.setting = mojom::Setting::kTrainAssistantVoiceModel}},
});
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment