Commit 7f2dc09e authored by rouslan@chromium.org's avatar rouslan@chromium.org

Do not use \u unicode characters directly in libaddressinput unit tests.

VisualStudio does not understand it \u escape sequences like \u00E8 in
UTF8 strings. The fix is to use Wide strings and convert them into UTF8
using base::WideToUTF8() utility.

BUG=395401

Review URL: https://codereview.chromium.org/403233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284629 0039d316-1c4b-4281-b951-d872f2087c98
parent cb41ac84
......@@ -10,6 +10,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_data.h"
#include "third_party/libaddressinput/src/cpp/include/libaddressinput/address_problem.h"
......@@ -247,7 +248,7 @@ TEST_F(AddressValidatorTest, BasicValidation) {
EXPECT_TRUE(problems.empty());
// Ignore diacriticals.
address.administrative_area = "T\u00E9xas";
address.administrative_area = base::WideToUTF8(L"T\u00E9xas");
problems.clear();
EXPECT_EQ(AddressValidator::SUCCESS,
validator_->ValidateAddress(address, NULL, &problems));
......
......@@ -4,13 +4,14 @@
#include "third_party/libaddressinput/src/cpp/src/util/string_compare.h"
#include "base/strings/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
TEST(ChromeStringCompareTest, IgnoreDiacritics) {
i18n::addressinput::StringCompare sc;
EXPECT_TRUE(sc.NaturalEquals("Texas", "T\u00E9xas"));
EXPECT_TRUE(sc.NaturalEquals("Texas", base::WideToUTF8(L"T\u00E9xas")));
}
TEST(ChromeStringCompareTest, IgnoreCapitalization) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment