Commit 7f3ec0c5 authored by Hiroshige Hayashizaki's avatar Hiroshige Hayashizaki Committed by Commit Bot

Revert "Enable VizHitTestDrawQuad feature by default on TOT for cros."

This reverts commit b5edc37e.

Reason for revert: suspected to cause flaky failures in
SitePerProcessBrowserTouchActionTest.EffectiveTouchActionPropagatesAcrossNestedFrames
While https://chromium-review.googlesource.com/1053907 enabled
the VizHitTestDrawQuad feature in fieldtrial_testing_config.json,
it doesn't seem to be applied to content_browsertests,
so this CL actually enabled that feature in this test and
possibly caused the flakiness. See crbug/910586.

Original change's description:
> Enable VizHitTestDrawQuad feature by default on TOT for cros.
>
> The OOPIF bug on cros was fixed
> https://bugs.chromium.org/p/chromium/issues/detail?id=877762,
> re-enabling VizHitTestDrawQuad by default for cros platforms.
>
> Bug: 804888
> Change-Id: I93cd237bc0631b6e1f77ae59232937697ce45ef2
> Reviewed-on: https://chromium-review.googlesource.com/c/1337644
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Ria Jiang <riajiang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608637}

TBR=sadrul@chromium.org,riajiang@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 804888, 910586
Change-Id: Ic42c16a2b0547878e1e794069f2057f18a74b337
Reviewed-on: https://chromium-review.googlesource.com/c/1356887
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: default avatarHiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612784}
parent da6b56b3
...@@ -30,8 +30,13 @@ const base::Feature kVizDisplayCompositor{"VizDisplayCompositor", ...@@ -30,8 +30,13 @@ const base::Feature kVizDisplayCompositor{"VizDisplayCompositor",
base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_DISABLED_BY_DEFAULT};
// Enables running the Viz-assisted hit-test logic. // Enables running the Viz-assisted hit-test logic.
#if defined(OS_CHROMEOS)
const base::Feature kEnableVizHitTestDrawQuad{
"VizHitTestDrawQuad", base::FEATURE_DISABLED_BY_DEFAULT};
#else
const base::Feature kEnableVizHitTestDrawQuad{"VizHitTestDrawQuad", const base::Feature kEnableVizHitTestDrawQuad{"VizHitTestDrawQuad",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
#endif
const base::Feature kEnableVizHitTestSurfaceLayer{ const base::Feature kEnableVizHitTestSurfaceLayer{
"VizHitTestSurfaceLayer", base::FEATURE_DISABLED_BY_DEFAULT}; "VizHitTestSurfaceLayer", base::FEATURE_DISABLED_BY_DEFAULT};
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment