Commit 7f7a2432 authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

IDL Compiler: Validate extended attributes in dictionaries and callback functions

IDL Compiler has been ignoring the validity of extended attributes on
dictionaries, callback functions, and their membmers.
This CL makes to do it.

Bug: 999690
Change-Id: Idcb88c6a346989e553a3bbe23e1273e00f8a04da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781902
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695033}
parent 579d02ad
......@@ -60,6 +60,15 @@ class IDLExtendedAttributeValidator(object):
self.validate_extended_attributes_node(operation)
for argument in operation.arguments:
self.validate_extended_attributes_node(argument)
for dictionary in definitions.dictionaries.itervalues():
self.validate_extended_attributes_node(dictionary)
for member in dictionary.members:
self.validate_extended_attributes_node(member)
for callback_function in definitions.callback_functions.itervalues():
self.validate_extended_attributes_node(callback_function)
for argument in callback_function.arguments:
self.validate_extended_attributes_node(argument)
def validate_extended_attributes_node(self, node):
for name, values_string in node.extended_attributes.iteritems():
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment