Enable TypeError for dictionary members of non-nullable interface type

In dictionary_v8.cpp, the extra null check was wrong or redudant
depending on nullabilty:

 * If the member isn't nullable, then passing null should throw
   TypeError.

 * If the member is nullable, then a null check is already emitted
   earlier, and so that part of the condition is always true.

The affected dictionaries were identified by looking at the resulting
changes in the generated bindings. Any affected member was made nullable
so that this change in itself is not observable, but the right behavior
is achieved if those changes are individually reverted.

A few cases that were not given TODOs:

 * MessageEventInit, because the existing TODO is appropriate.

 * MediaStreamEventInit, because it has no spec and MediaStreamEvent's
   corresponding attribute is already nullable.

 * SpeechRecognitionEventInit, because it has no spec.
   SpeechRecognitionEvent's attributes were made nullable because they
   can now in fact be null.

A number of spec issues were discovered, linked with the TODOs.

BUG=647693

Review-Url: https://codereview.chromium.org/2342393002
Cr-Commit-Position: refs/heads/master@{#419344}

third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp

@@ -68,7 +68,7 @@ void {{v8_class}}::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value, {{
         {% endif %}
         {{v8_value_to_local_cpp_value(member) | indent(8)}}
         {% if member.is_interface_type %}
-        if (!{{member.name}} && !{{member.name}}Value->IsNull()) {
+        if (!{{member.name}}) {
             exceptionState.throwTypeError("member {{member.name}} is not of type {{member.idl_type}}.");
             return;
         }

third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp

@@ -170,7 +170,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         impl.setElementOrNullMemberToNull();
     } else {
         Element* elementOrNullMember = V8Element::toImplWithTypeCheck(isolate, elementOrNullMemberValue);
-        if (!elementOrNullMember && !elementOrNullMemberValue->IsNull()) {
+        if (!elementOrNullMember) {
             exceptionState.throwTypeError("member elementOrNullMember is not of type Element.");
             return;
         }
@@ -230,7 +230,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         // Do nothing.
     } else {
         EventTarget* eventTargetMember = toEventTarget(isolate, eventTargetMemberValue);
-        if (!eventTargetMember && !eventTargetMemberValue->IsNull()) {
+        if (!eventTargetMember) {
             exceptionState.throwTypeError("member eventTargetMember is not of type EventTarget.");
             return;
         }
@@ -426,7 +426,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         // Do nothing.
     } else {
         TestInterfaceGarbageCollected* testInterfaceGarbageCollectedMember = V8TestInterfaceGarbageCollected::toImplWithTypeCheck(isolate, testInterfaceGarbageCollectedMemberValue);
-        if (!testInterfaceGarbageCollectedMember && !testInterfaceGarbageCollectedMemberValue->IsNull()) {
+        if (!testInterfaceGarbageCollectedMember) {
             exceptionState.throwTypeError("member testInterfaceGarbageCollectedMember is not of type TestInterfaceGarbageCollected.");
             return;
         }
@@ -444,7 +444,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         impl.setTestInterfaceGarbageCollectedOrNullMemberToNull();
     } else {
         TestInterfaceGarbageCollected* testInterfaceGarbageCollectedOrNullMember = V8TestInterfaceGarbageCollected::toImplWithTypeCheck(isolate, testInterfaceGarbageCollectedOrNullMemberValue);
-        if (!testInterfaceGarbageCollectedOrNullMember && !testInterfaceGarbageCollectedOrNullMemberValue->IsNull()) {
+        if (!testInterfaceGarbageCollectedOrNullMember) {
             exceptionState.throwTypeError("member testInterfaceGarbageCollectedOrNullMember is not of type TestInterfaceGarbageCollected.");
             return;
         }
@@ -474,7 +474,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         // Do nothing.
     } else {
         TestInterfaceImplementation* testInterfaceMember = V8TestInterface::toImplWithTypeCheck(isolate, testInterfaceMemberValue);
-        if (!testInterfaceMember && !testInterfaceMemberValue->IsNull()) {
+        if (!testInterfaceMember) {
             exceptionState.throwTypeError("member testInterfaceMember is not of type TestInterface.");
             return;
         }
@@ -492,7 +492,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         impl.setTestInterfaceOrNullMemberToNull();
     } else {
         TestInterfaceImplementation* testInterfaceOrNullMember = V8TestInterface::toImplWithTypeCheck(isolate, testInterfaceOrNullMemberValue);
-        if (!testInterfaceOrNullMember && !testInterfaceOrNullMemberValue->IsNull()) {
+        if (!testInterfaceOrNullMember) {
             exceptionState.throwTypeError("member testInterfaceOrNullMember is not of type TestInterface.");
             return;
         }
@@ -522,7 +522,7 @@ void V8TestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value
         // Do nothing.
     } else {
         DOMUint8Array* uint8ArrayMember = uint8ArrayMemberValue->IsUint8Array() ? V8Uint8Array::toImpl(v8::Local<v8::Uint8Array>::Cast(uint8ArrayMemberValue)) : 0;
-        if (!uint8ArrayMember && !uint8ArrayMemberValue->IsNull()) {
+        if (!uint8ArrayMember) {
             exceptionState.throwTypeError("member uint8ArrayMember is not of type Uint8Array.");
             return;
         }

third_party/WebKit/Source/core/dom/TouchInit.idl

@@ -6,7 +6,8 @@
 
 dictionary TouchInit {
     required long        identifier;
-    required EventTarget target;
+    // TODO(foolip): |target| should not be nullable. https://crbug.com/647693
+    required EventTarget? target;
              double      clientX = 0;
              double      clientY = 0;
              double      screenX = 0;

third_party/WebKit/Source/core/events/MessageEventInit.idl

@@ -9,7 +9,7 @@ dictionary MessageEventInit : EventInit {
     DOMString origin;
     DOMString lastEventId;
     // TODO(bashi): |source| should be (WindowProxy or MessagePort)?
-    EventTarget source;
+    EventTarget? source;
     // Per spec, |ports| isn't nullable, but it seems it should be.
     // https://www.w3.org/Bugs/Public/show_bug.cgi?id=23176
     sequence<MessagePort>? ports;

third_party/WebKit/Source/modules/encryptedmedia/MediaKeyMessageEventInit.idl

@@ -6,5 +6,8 @@
 
 dictionary MediaKeyMessageEventInit : EventInit {
     MediaKeyMessageType messageType = "license-request";
-    ArrayBuffer message;
+    // TODO(foolip): |message| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/w3c/encrypted-media/issues/329
+    ArrayBuffer? message;
 };

third_party/WebKit/Source/modules/gamepad/GamepadEvent.idl

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#gamepadevent-interface
+// https://w3c.github.io/gamepad/#gamepadevent-interface
 
 [
     Constructor(DOMString type, optional GamepadEventInit eventInitDict),

third_party/WebKit/Source/modules/gamepad/GamepadEventInit.idl

@@ -2,8 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://dvcs.w3.org/hg/gamepad/raw-file/default/gamepad.html#gamepadevent-interface
+// https://w3c.github.io/gamepad/#gamepadevent-interface
 
 dictionary GamepadEventInit : EventInit {
-    Gamepad gamepad;
+    // TODO(foolip): |gamepad| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/w3c/gamepad/issues/35
+    Gamepad? gamepad;
 };

third_party/WebKit/Source/modules/mediarecorder/BlobEventInit.idl

@@ -5,5 +5,6 @@
 // https://w3c.github.io/mediacapture-record/MediaRecorder.html#blobeventinit
 
 dictionary BlobEventInit : EventInit {
-    required Blob data;
+    // TODO(foolip): |data| should not be nullable. https://crbug.com/647693
+    required Blob? data;
 };

third_party/WebKit/Source/modules/mediastream/MediaStreamEventInit.idl

@@ -5,5 +5,5 @@
 // http://www.w3.org/TR/webrtc/#mediastreamevent
 
 dictionary MediaStreamEventInit : EventInit {
-    MediaStream stream;
+    MediaStream? stream;
 };

third_party/WebKit/Source/modules/notifications/NotificationEventInit.idl

@@ -5,6 +5,8 @@
 // https://notifications.spec.whatwg.org/#notificationevent
 
 dictionary NotificationEventInit : ExtendableEventInit {
-    required Notification notification;
+    // TODO(foolip): |notification| should not be nullable.
+    // https://crbug.com/647693
+    required Notification? notification;
     DOMString action = "";
 };

third_party/WebKit/Source/modules/presentation/PresentationConnectionAvailableEventInit.idl

@@ -5,5 +5,7 @@
 // https://w3c.github.io/presentation-api/#idl-def-presentationconnectionavailableeventinit
 
 dictionary PresentationConnectionAvailableEventInit : EventInit {
-    required PresentationConnection connection;
+    // TODO(foolip): |connection| should not be nullable.
+    // https://crbug.com/647693
+    required PresentationConnection? connection;
 };

third_party/WebKit/Source/modules/sensor/SensorReadingEventInit.idl

@@ -6,5 +6,8 @@
 // https://w3c.github.io/sensors/#dictdef-sensorreadingeventinit
 
 dictionary SensorReadingEventInit : EventInit {
-    SensorReading reading;
+    // TODO(foolip): |reading| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/w3c/sensors/issues/129
+    SensorReading? reading;
 };

third_party/WebKit/Source/modules/serviceworkers/FetchEventInit.idl

@@ -2,10 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#fetch-event-interface
+// https://w3c.github.io/ServiceWorker/#fetch-event-interface
 
 dictionary FetchEventInit : ExtendableEventInit {
-  required Request request;
+  // TODO(foolip): |request| should not be nullable. https://crbug.com/647693
+  required Request? request;
   DOMString? clientId = null;
   boolean isReload = false;
 };

third_party/WebKit/Source/modules/serviceworkers/ForeignFetchEventInit.idl

@@ -2,9 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#dictdef-foreignfetchevent-foreignfetcheventinit
+// https://w3c.github.io/ServiceWorker/#dictdef-foreignfetchevent-foreignfetcheventinit
 
 dictionary ForeignFetchEventInit : ExtendableEventInit {
-  required Request request;
+  // TODO(foolip): |request| should not be nullable. https://crbug.com/647693
+  required Request? request;
   USVString origin = "null";
 };

third_party/WebKit/Source/modules/serviceworkers/ForeignFetchResponse.idl

@@ -2,10 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#dictdef-foreignfetchevent-foreignfetchresponse
+// https://w3c.github.io/ServiceWorker/#dictdef-foreignfetchevent-foreignfetchresponse
 
 dictionary ForeignFetchResponse {
-  required Response response;
+  // TODO(foolip): |response| should not be nullable. https://crbug.com/647693
+  required Response? response;
   USVString origin;
   sequence<ByteString> headers;
 };

third_party/WebKit/Source/modules/speech/SpeechRecognitionEvent.idl

@@ -28,8 +28,8 @@
     Constructor(DOMString type, optional SpeechRecognitionEventInit initDict),
 ] interface SpeechRecognitionEvent : Event {
     readonly attribute unsigned long resultIndex;
-    readonly attribute SpeechRecognitionResultList results;
+    readonly attribute SpeechRecognitionResultList? results;
 
-    readonly attribute Document interpretation;
-    readonly attribute Document emma;
+    readonly attribute Document? interpretation;
+    readonly attribute Document? emma;
 };

third_party/WebKit/Source/modules/speech/SpeechRecognitionEventInit.idl

@@ -6,5 +6,5 @@
 
 dictionary SpeechRecognitionEventInit : EventInit {
     unsigned long resultIndex;
-    SpeechRecognitionResultList results;
+    SpeechRecognitionResultList? results;
 };

third_party/WebKit/Source/modules/vr/VRDisplayEventInit.idl

@@ -6,6 +6,9 @@
 [
     RuntimeEnabled=WebVR
 ] dictionary VRDisplayEventInit : EventInit {
-    VRDisplay display;
+    // TODO(foolip): |display| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/w3c/webvr/issues/83
+    VRDisplay? display;
     VRDisplayEventReason reason;
 };

third_party/WebKit/Source/modules/webmidi/MIDIConnectionEventInit.idl

@@ -5,5 +5,8 @@
 // http://webaudio.github.io/web-midi-api/#idl-def-MIDIConnectionEventInit
 
 dictionary MIDIConnectionEventInit : EventInit {
-    MIDIPort port;
+    // TODO(foolip): |port| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/WebAudio/web-midi-api/issues/168
+    MIDIPort? port;
 };

third_party/WebKit/Source/modules/webmidi/MIDIMessageEventInit.idl

@@ -6,5 +6,8 @@
 
 dictionary MIDIMessageEventInit : EventInit {
     double receivedTime;
-    Uint8Array data;
+    // TODO(foolip): |data| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/WebAudio/web-midi-api/issues/168
+    Uint8Array? data;
 };

third_party/WebKit/Source/modules/webusb/USBConnectionEventInit.idl

@@ -5,5 +5,8 @@
 // http://wicg.github.io/webusb/#events
 
 dictionary USBConnectionEventInit : EventInit {
-    USBDevice device;
+    // TODO(foolip): |device| should be required and not nullable.
+    // https://crbug.com/647693
+    // https://github.com/WICG/webusb/issues/63
+    USBDevice? device;
 };