Commit 7f92a72e authored by tzik's avatar tzik Committed by Commit Bot

Remove FILE thread from sync_file_system tests

This CL removes all dependencies to BrowserThread::FILE in sync_file_system,
and replaces them with base/task_scheduler's ones.

Change-Id: Idd3ffb66d2d3079f3b6b680bde8b016d696ce268
Reviewed-on: https://chromium-review.googlesource.com/575735
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: default avatarHiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487456}
parent 780e6a15
...@@ -93,8 +93,7 @@ class DriveBackendSyncTest : public testing::Test, ...@@ -93,8 +93,7 @@ class DriveBackendSyncTest : public testing::Test,
content::BrowserThread::IO); content::BrowserThread::IO);
worker_task_runner_ = base::CreateSequencedTaskRunnerWithTraits( worker_task_runner_ = base::CreateSequencedTaskRunnerWithTraits(
{base::MayBlock(), base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN}); {base::MayBlock(), base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN});
file_task_runner_ = content::BrowserThread::GetTaskRunnerForThread( file_task_runner_ = io_task_runner_;
content::BrowserThread::FILE);
scoped_refptr<base::SequencedTaskRunner> drive_task_runner = scoped_refptr<base::SequencedTaskRunner> drive_task_runner =
base::CreateSequencedTaskRunnerWithTraits( base::CreateSequencedTaskRunnerWithTraits(
{base::MayBlock(), base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN}); {base::MayBlock(), base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN});
......
...@@ -59,9 +59,7 @@ const char kOrigin2[] = "http://chromium.org"; ...@@ -59,9 +59,7 @@ const char kOrigin2[] = "http://chromium.org";
class LocalFileSyncContextTest : public testing::Test { class LocalFileSyncContextTest : public testing::Test {
protected: protected:
LocalFileSyncContextTest() LocalFileSyncContextTest()
: thread_bundle_( : thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD),
content::TestBrowserThreadBundle::REAL_FILE_THREAD |
content::TestBrowserThreadBundle::REAL_IO_THREAD),
status_(SYNC_FILE_ERROR_FAILED), status_(SYNC_FILE_ERROR_FAILED),
file_error_(base::File::FILE_ERROR_FAILED), file_error_(base::File::FILE_ERROR_FAILED),
async_modify_finished_(false), async_modify_finished_(false),
......
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "base/macros.h" #include "base/macros.h"
#include "base/run_loop.h" #include "base/run_loop.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/task_scheduler/post_task.h"
#include "base/threading/thread.h" #include "base/threading/thread.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
#include "build/build_config.h" #include "build/build_config.h"
...@@ -108,8 +109,7 @@ class LocalFileSyncServiceTest ...@@ -108,8 +109,7 @@ class LocalFileSyncServiceTest
public LocalFileSyncService::Observer { public LocalFileSyncService::Observer {
protected: protected:
LocalFileSyncServiceTest() LocalFileSyncServiceTest()
: thread_bundle_(content::TestBrowserThreadBundle::REAL_FILE_THREAD | : thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD),
content::TestBrowserThreadBundle::REAL_IO_THREAD),
num_changes_(0) {} num_changes_(0) {}
void SetUp() override { void SetUp() override {
...@@ -119,7 +119,7 @@ class LocalFileSyncServiceTest ...@@ -119,7 +119,7 @@ class LocalFileSyncServiceTest
file_system_.reset(new CannedSyncableFileSystem( file_system_.reset(new CannedSyncableFileSystem(
GURL(kOrigin), in_memory_env_.get(), GURL(kOrigin), in_memory_env_.get(),
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO), BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE))); base::CreateSingleThreadTaskRunnerWithTraits({base::MayBlock()})));
local_service_ = LocalFileSyncService::CreateForTesting( local_service_ = LocalFileSyncService::CreateForTesting(
&profile_, in_memory_env_.get()); &profile_, in_memory_env_.get());
...@@ -145,7 +145,8 @@ class LocalFileSyncServiceTest ...@@ -145,7 +145,8 @@ class LocalFileSyncServiceTest
local_service_->Shutdown(); local_service_->Shutdown();
file_system_->TearDown(); file_system_->TearDown();
RevokeSyncableFileSystem(); RevokeSyncableFileSystem();
content::RunAllPendingInMessageLoop(BrowserThread::FILE);
base::TaskScheduler::GetInstance()->FlushForTesting();
content::RunAllPendingInMessageLoop(BrowserThread::IO); content::RunAllPendingInMessageLoop(BrowserThread::IO);
} }
...@@ -301,7 +302,7 @@ TEST_F(LocalFileSyncServiceTest, MAYBE_LocalChangeObserverMultipleContexts) { ...@@ -301,7 +302,7 @@ TEST_F(LocalFileSyncServiceTest, MAYBE_LocalChangeObserverMultipleContexts) {
CannedSyncableFileSystem file_system2( CannedSyncableFileSystem file_system2(
GURL(kOrigin2), in_memory_env_.get(), GURL(kOrigin2), in_memory_env_.get(),
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO), BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE)); base::CreateSingleThreadTaskRunnerWithTraits({base::MayBlock()}));
file_system2.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED); file_system2.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
base::RunLoop run_loop; base::RunLoop run_loop;
......
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include "base/single_thread_task_runner.h" #include "base/single_thread_task_runner.h"
#include "base/stl_util.h" #include "base/stl_util.h"
#include "base/synchronization/waitable_event.h" #include "base/synchronization/waitable_event.h"
#include "base/task_scheduler/post_task.h"
#include "base/threading/thread_task_runner_handle.h" #include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/sync_file_system/local/canned_syncable_file_system.h" #include "chrome/browser/sync_file_system/local/canned_syncable_file_system.h"
#include "chrome/browser/sync_file_system/local/local_file_sync_context.h" #include "chrome/browser/sync_file_system/local/local_file_sync_context.h"
...@@ -128,15 +129,14 @@ ACTION(InvokeCompletionClosure) { ...@@ -128,15 +129,14 @@ ACTION(InvokeCompletionClosure) {
class SyncFileSystemServiceTest : public testing::Test { class SyncFileSystemServiceTest : public testing::Test {
protected: protected:
SyncFileSystemServiceTest() SyncFileSystemServiceTest()
: thread_bundle_(content::TestBrowserThreadBundle::REAL_FILE_THREAD | : thread_bundle_(content::TestBrowserThreadBundle::REAL_IO_THREAD) {}
content::TestBrowserThreadBundle::REAL_IO_THREAD) {}
void SetUp() override { void SetUp() override {
in_memory_env_.reset(leveldb::NewMemEnv(leveldb::Env::Default())); in_memory_env_.reset(leveldb::NewMemEnv(leveldb::Env::Default()));
file_system_.reset(new CannedSyncableFileSystem( file_system_.reset(new CannedSyncableFileSystem(
GURL(kOrigin), in_memory_env_.get(), GURL(kOrigin), in_memory_env_.get(),
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO), BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
BrowserThread::GetTaskRunnerForThread(BrowserThread::FILE))); base::CreateSingleThreadTaskRunnerWithTraits({base::MayBlock()})));
std::unique_ptr<LocalFileSyncService> local_service = std::unique_ptr<LocalFileSyncService> local_service =
LocalFileSyncService::CreateForTesting(&profile_, in_memory_env_.get()); LocalFileSyncService::CreateForTesting(&profile_, in_memory_env_.get());
...@@ -168,7 +168,7 @@ class SyncFileSystemServiceTest : public testing::Test { ...@@ -168,7 +168,7 @@ class SyncFileSystemServiceTest : public testing::Test {
sync_service_->Shutdown(); sync_service_->Shutdown();
file_system_->TearDown(); file_system_->TearDown();
RevokeSyncableFileSystem(); RevokeSyncableFileSystem();
content::RunAllPendingInMessageLoop(BrowserThread::FILE); base::TaskScheduler::GetInstance()->FlushForTesting();
} }
void InitializeApp() { void InitializeApp() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment