Commit 7f96587e authored by Friedrich Horschig's avatar Friedrich Horschig Committed by Commit Bot

[Android][TouchToFill] Increase half-state height to show 2+ suggestions

This cl increases the height of the touch to fill sheet to show a second
suggestion by default. To keep the height consistent, the peeking height
for the third suggestion was reduced.

It now looks according to the mocks linked in the linked bug.

Bug: 1029704
Change-Id: I52bbb15c3ee6cf9bc423a4745168addced02d69d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945172Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720506}
parent d96fa9e6
...@@ -9,17 +9,17 @@ ...@@ -9,17 +9,17 @@
<!-- Below are the different Half-state peeking heights. The height is the <!-- Below are the different Half-state peeking heights. The height is the
sum of all components. It varies depending on the suggestion count. The sum of all components. It varies depending on the suggestion count. The
base height is 282dp: base height is 298dp:
Bottom sheet shadows and padding (18dp) Bottom sheet shadows and padding (18dp)
+ Handlebar (16dp) + Handlebar (16dp)
+ Header size (112 dp) + Header size (112 dp)
+ Title size and margin (48+16dp) + Title size and margin (48+16dp)
+ First suggestion (72dp) --> + First suggestion (72dp)
<!-- Base height (282dp) plus padding (8dp) plus half suggestion (36dp) --> + Bottom padding (16dp) -->
<dimen name="touch_to_fill_sheet_height_multiple_credentials">326dp</dimen>
<!-- Base height (282dp) plus bottom padding (16dp) -->
<dimen name="touch_to_fill_sheet_height_single_credential">298dp</dimen> <dimen name="touch_to_fill_sheet_height_single_credential">298dp</dimen>
<!-- Base height (282dp) + confirm button with paddings (48+2*16dp) --> <!-- Base height (298dp) plus padding (8dp) plus 2nd suggestion (72dp) -->
<dimen name="touch_to_fill_sheet_height_multiple_credentials">378dp</dimen>
<!-- Base height (298dp) plus padding (16dp) plus confirm button (48dp) -->
<dimen name="touch_to_fill_sheet_height_single_credential_with_button"> <dimen name="touch_to_fill_sheet_height_single_credential_with_button">
362dp 362dp
</dimen> </dimen>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment