Commit 7fb61e6e authored by Wenyu Fu's avatar Wenyu Fu Committed by Commit Bot

Fix RadioButtonGroupHomepagePreference to gain focus

Starting the HomepageSettings, the RadioButtonGroupHomepagePreference
will gain focus automatically and have a highlight background on it.
This CL disables the focusableInTouchMode attribute in the xml.

Bug: 1052498
Change-Id: If89f92fca8195bd4289648511356a2264a55bbcf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060657
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: default avatarNatalie Chouinard <chouinard@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744332}
parent 80797184
......@@ -8,8 +8,6 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:focusable="true"
android:focusableInTouchMode="true"
android:orientation="vertical">
<!-- TODO(crbug.com/1048859): Change to the exact style TextMessagePreference is using. -->
......@@ -27,7 +25,8 @@
<org.chromium.components.browser_ui.widget.RadioButtonWithDescriptionLayout
android:id="@+id/radio_button_group"
android:layout_width="match_parent"
android:layout_height="wrap_content">
android:layout_height="wrap_content"
android:focusableInTouchMode="true">
<!-- TODO(crbug.com/1048863): Remove android:background for radio buttons here and below after enhancement. -->
<org.chromium.components.browser_ui.widget.RadioButtonWithDescription
......
......@@ -21,6 +21,7 @@
<org.chromium.chrome.browser.settings.homepage.RadioButtonGroupHomepagePreference
android:key="homepage_radio_group"
android:visibility="gone"
android:selectable="false"
app:allowDividerBelow="false" />
<org.chromium.chrome.browser.settings.TextMessagePreference
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment