Commit 7fbbd5f2 authored by Robert Liao's avatar Robert Liao Committed by Commit Bot

Use the Native Certificate Viewer on MacOS even on MacViews

BUG=766926

Change-Id: I6d0302763687bbb4fe30682684ad85a2ac79f782
Reviewed-on: https://chromium-review.googlesource.com/1145674Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577201}
parent 0178fa89
...@@ -142,14 +142,11 @@ void ShowSSLClientCertificateSelector( ...@@ -142,14 +142,11 @@ void ShowSSLClientCertificateSelector(
net::ClientCertIdentityList client_certs, net::ClientCertIdentityList client_certs,
std::unique_ptr<content::ClientCertificateDelegate> delegate) { std::unique_ptr<content::ClientCertificateDelegate> delegate) {
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
// TODO(ellyjones): Always use the Cocoa cert selector, even in Views builds. return ShowSSLClientCertificateSelectorCocoa(contents, cert_request_info,
// See also https://crbug.com/804950. std::move(client_certs),
if (views_mode_controller::IsViewsBrowserCocoa()) { std::move(delegate));
return ShowSSLClientCertificateSelectorCocoa(contents, cert_request_info, #else // defined(OS_MACOSX)
std::move(client_certs),
std::move(delegate));
}
#endif
DCHECK_CURRENTLY_ON(content::BrowserThread::UI); DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// Not all WebContentses can show modal dialogs. // Not all WebContentses can show modal dialogs.
...@@ -164,6 +161,7 @@ void ShowSSLClientCertificateSelector( ...@@ -164,6 +161,7 @@ void ShowSSLClientCertificateSelector(
std::move(delegate)); std::move(delegate));
selector->Init(); selector->Init();
selector->Show(); selector->Show();
#endif // defined(OS_MACOSX)
} }
} // namespace chrome } // namespace chrome
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment