Commit 7fbe5725 authored by Esmael El-Moslimany's avatar Esmael El-Moslimany Committed by Commit Bot

Settings WebUI: leave settings menu drawer open after clicking extensions (external) link

Bug: 827112
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5f92210573a235f67cc919ab4b7e2082c3f9b75e
Reviewed-on: https://chromium-review.googlesource.com/986662Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546973}
parent 26d68c97
...@@ -92,6 +92,5 @@ Polymer({ ...@@ -92,6 +92,5 @@ Polymer({
onExtensionsLinkClick_: function() { onExtensionsLinkClick_: function() {
chrome.metricsPrivate.recordUserAction( chrome.metricsPrivate.recordUserAction(
'SettingsMenu_ExtensionsLinkClicked'); 'SettingsMenu_ExtensionsLinkClicked');
this.fire('external-link-click');
}, },
}); });
...@@ -82,10 +82,6 @@ Polymer({ ...@@ -82,10 +82,6 @@ Polymer({
this.$.drawerTemplate.if = true; this.$.drawerTemplate.if = true;
}); });
this.addEventListener('external-link-click', () => {
this.$.drawer.closeDrawer();
});
window.addEventListener('popstate', e => { window.addEventListener('popstate', e => {
this.$.drawer.closeDrawer(); this.$.drawer.closeDrawer();
}); });
......
...@@ -1276,7 +1276,6 @@ CrSettingsMenuTest.prototype = { ...@@ -1276,7 +1276,6 @@ CrSettingsMenuTest.prototype = {
/** @override */ /** @override */
extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([ extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
'test_util.js',
'settings_menu_test.js', 'settings_menu_test.js',
]), ]),
}; };
......
...@@ -75,13 +75,6 @@ cr.define('settings_menu', function() { ...@@ -75,13 +75,6 @@ cr.define('settings_menu', function() {
MockInteractions.tap(settingsMenu.$.people); MockInteractions.tap(settingsMenu.$.people);
assertEquals('', settings.getQueryParameters().toString()); assertEquals('', settings.getQueryParameters().toString());
}); });
test('extensionsLinkClicked', function() {
const eventPromise =
test_util.eventToPromise('external-link-click', settingsMenu);
settingsMenu.$.extensionsLink.click();
return eventPromise;
});
}); });
suite('SettingsMenuReset', function() { suite('SettingsMenuReset', function() {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment