Settings WebUI: leave settings menu drawer open after clicking extensions (external) link

Bug: 827112
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I5f92210573a235f67cc919ab4b7e2082c3f9b75e
Reviewed-on: https://chromium-review.googlesource.com/986662Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546973}

chrome/browser/resources/settings/settings_menu/settings_menu.js

@@ -92,6 +92,5 @@ Polymer({
   onExtensionsLinkClick_: function() {
     chrome.metricsPrivate.recordUserAction(
         'SettingsMenu_ExtensionsLinkClicked');
-    this.fire('external-link-click');
   },
 });

chrome/browser/resources/settings/settings_ui/settings_ui.js

@@ -82,10 +82,6 @@ Polymer({
       this.$.drawerTemplate.if = true;
     });
 
-    this.addEventListener('external-link-click', () => {
-      this.$.drawer.closeDrawer();
-    });
-
     window.addEventListener('popstate', e => {
       this.$.drawer.closeDrawer();
     });

chrome/test/data/webui/settings/cr_settings_browsertest.js

@@ -1276,7 +1276,6 @@ CrSettingsMenuTest.prototype = {
 
   /** @override */
   extraLibraries: CrSettingsBrowserTest.prototype.extraLibraries.concat([
-    'test_util.js',
     'settings_menu_test.js',
   ]),
 };

chrome/test/data/webui/settings/settings_menu_test.js

@@ -75,13 +75,6 @@ cr.define('settings_menu', function() {
       MockInteractions.tap(settingsMenu.$.people);
       assertEquals('', settings.getQueryParameters().toString());
     });
-
-    test('extensionsLinkClicked', function() {
-      const eventPromise =
-          test_util.eventToPromise('external-link-click', settingsMenu);
-      settingsMenu.$.extensionsLink.click();
-      return eventPromise;
-    });
   });
 
   suite('SettingsMenuReset', function() {