Commit 7fe8c8d0 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Use |base::kInvalidFd| in PrintingContextAndroid.

Change-Id: I64b2f250e6d7573a9b3a5145d1a4f4f530b813a3
Reviewed-on: https://chromium-review.googlesource.com/c/1441958Reviewed-by: default avatarShimi Zhang <ctzsm@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#626939}
parent b95cf6bb
...@@ -8,6 +8,7 @@ ...@@ -8,6 +8,7 @@
#include <string> #include <string>
#include "base/android/scoped_java_ref.h" #include "base/android/scoped_java_ref.h"
#include "base/file_descriptor_posix.h"
#include "base/macros.h" #include "base/macros.h"
#include "printing/printing_context.h" #include "printing/printing_context.h"
...@@ -60,8 +61,7 @@ class PRINTING_EXPORT PrintingContextAndroid : public PrintingContext { ...@@ -60,8 +61,7 @@ class PRINTING_EXPORT PrintingContextAndroid : public PrintingContext {
printing::NativeDrawingContext context() const override; printing::NativeDrawingContext context() const override;
private: private:
// TODO(thestig): Use |base::kInvalidFd| once available. bool is_file_descriptor_valid() const { return fd_ > base::kInvalidFd; }
bool is_file_descriptor_valid() const { return fd_ > -1; }
base::android::ScopedJavaGlobalRef<jobject> j_printing_context_; base::android::ScopedJavaGlobalRef<jobject> j_printing_context_;
...@@ -69,7 +69,7 @@ class PRINTING_EXPORT PrintingContextAndroid : public PrintingContext { ...@@ -69,7 +69,7 @@ class PRINTING_EXPORT PrintingContextAndroid : public PrintingContext {
// ready on the Java side // ready on the Java side
PrintSettingsCallback callback_; PrintSettingsCallback callback_;
int fd_ = -1; int fd_ = base::kInvalidFd;
DISALLOW_COPY_AND_ASSIGN(PrintingContextAndroid); DISALLOW_COPY_AND_ASSIGN(PrintingContextAndroid);
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment