Commit 7ffb762f authored by Wenbin Zhang's avatar Wenbin Zhang Committed by Commit Bot

[benchmarking] Marking some rendering stoires as desktop only

crrev/c/2459799 added [Skip] tag for the stories:
animometer_webgl_indexed, animometer_webgl_indexed_multi_draw_base_vertex_base_instance, animometer_webgl_indexed_multi_draw

Though, even if they're skipped, the current logic still checks their achieve status.

This CL will set those stories as DESKTOP_ONLY. Synced with Shrek and these stories will not be ready for mobile for now.
Expectation file needs to be update to pass the PRESUBMIT, which complains that the tag on expecation does not apply to those stories.

Will be another CL to update the logic to skip the achieve checking logic.

Bug: chromium:1136227
Change-Id: I52f4b10b6c3399634611cb69d7b33f66c843ae52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462226
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
Reviewed-by: default avatarShrek Shao <shrekshao@google.com>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#815646}
parent 0e3fa771
......@@ -255,9 +255,6 @@ crbug.com/1036357 [ android-nexus-5 ] rendering.mobile/idle_power_blank [ Skip ]
crbug.com/1036357 [ android-nexus-5 ] rendering.mobile/balls_svg_animations [ Skip ]
crbug.com/1116469 [ android-webview ] rendering.mobile/webgl_to_texture [ Skip ]
crbug.com/1124237 [ android-nexus-5x android-webview ] rendering.mobile/toBlob_duration.html [ Skip ]
crbug.com/1136227 [ android-pixel-2 android-webview ] rendering.mobile/animometer_webgl_indexed [ Skip ]
crbug.com/1136227 [ android-pixel-2 android-webview ] rendering.mobile/animometer_webgl_indexed_multi_draw_base_vertex_base_instance [ Skip ]
crbug.com/1136227 [ android-pixel-2 android-webview ] rendering.mobile/animometer_webgl_indexed_multi_draw [ Skip ]
# Benchmark: rasterize_and_record_micro.top_25
crbug.com/764543 rasterize_and_record_micro.top_25/file://static_top_25/wikipedia.html [ Skip ]
......
......@@ -4,6 +4,7 @@
from page_sets.rendering import rendering_story
from page_sets.rendering import story_tags
from page_sets.system_health import platforms
class ToughWebglPage(rendering_story.RenderingStory):
......@@ -107,18 +108,21 @@ class AnimometerWebGLMultiDrawPage(ToughWebglPage):
class AnimometerWebGLIndexed(ToughWebglPage):
BASE_NAME = 'animometer_webgl_indexed'
SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
# pylint: disable=line-too-long
URL = 'http://kenrussell.github.io/webgl-animometer/Animometer/tests/3d/webgl-indexed-instanced.html?webgl_version=2&use_attributes=1&num_geometries=120000'
class AnimometerWebGLIndexedMultiDraw(ToughWebglPage):
BASE_NAME = 'animometer_webgl_indexed_multi_draw'
SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
# pylint: disable=line-too-long
URL = 'http://kenrussell.github.io/webgl-animometer/Animometer/tests/3d/webgl-indexed-instanced.html?webgl_version=2&use_attributes=1&use_multi_draw=1&num_geometries=120000'
class AnimometerWebGLIndexedBaseVertexBaseInstancePage(ToughWebglPage):
BASE_NAME = 'animometer_webgl_indexed_multi_draw_base_vertex_base_instance'
SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
# pylint: disable=line-too-long
URL = 'http://kenrussell.github.io/webgl-animometer/Animometer/tests/3d/webgl-indexed-instanced.html?webgl_version=2&use_attributes=1&use_multi_draw=1&use_base_vertex_base_instance=1&num_geometries=120000'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment