Simplify Dictionary::ConversionContext

- Nobody uses the forConstructor().
- m_interfaceName and m_methodName are passed, but nobody uses them.

BUG=433174

Review URL: https://codereview.chromium.org/724183004

git-svn-id: svn://svn.chromium.org/blink/trunk@185360 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/bindings/core/v8/Dictionary.h

@@ -76,18 +76,13 @@ public:
 
     class ConversionContext {
     public:
-        ConversionContext(const String& interfaceName, const String& methodName, ExceptionState& exceptionState)
-            : m_interfaceName(interfaceName)
-            , m_methodName(methodName)
-            , m_exceptionState(exceptionState)
+        explicit ConversionContext(ExceptionState& exceptionState)
+            : m_exceptionState(exceptionState)
             , m_dirty(true)
         {
             resetPerPropertyContext();
         }
 
-        const String& interfaceName() const { return m_interfaceName; }
-        const String& methodName() const { return m_methodName; }
-        bool forConstructor() const { return m_methodName.isEmpty(); }
         ExceptionState& exceptionState() const { return m_exceptionState; }
 
         bool isNullable() const { return m_isNullable; }
@@ -100,8 +95,6 @@ public:
         void resetPerPropertyContext();
 
     private:
-        const String m_interfaceName;
-        const String m_methodName;
         ExceptionState& m_exceptionState;
         bool m_dirty;
 
@@ -111,7 +104,7 @@ public:
 
     class ConversionContextScope {
     public:
-        ConversionContextScope(ConversionContext& context)
+        explicit ConversionContextScope(ConversionContext& context)
             : m_context(context) { }
         ~ConversionContextScope()
         {

third_party/WebKit/Source/bindings/templates/interface.cpp

@@ -617,11 +617,11 @@ static const V8DOMConfiguration::AttributeConfiguration shadowAttributes[] = {
 {##############################################################################}
 {% block initialize_event %}
 {% if has_event_constructor %}
-bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info, const String& forEventName)
+bool initialize{{cpp_class}}({{cpp_class}}Init& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    Dictionary::ConversionContext conversionContext(forEventName.isEmpty() ? String("{{interface_name}}") : forEventName, "", exceptionState);
+    Dictionary::ConversionContext conversionContext(exceptionState);
     {% if parent_interface %}{# any Event interface except Event itself #}
-    if (!initialize{{parent_interface}}(eventInit, options, exceptionState, info, forEventName.isEmpty() ? String("{{interface_name}}") : forEventName))
+    if (!initialize{{parent_interface}}(eventInit, options, exceptionState, info))
         return false;
 
     {% endif %}

third_party/WebKit/Source/bindings/templates/interface.h

@@ -235,7 +235,7 @@ inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo, {{cpp_class}}
 
 {% endif %}{# has_custom_to_v8 #}
 {% if has_event_constructor %}
-bool initialize{{cpp_class}}({{cpp_class}}Init&, const Dictionary&, ExceptionState&, const v8::FunctionCallbackInfo<v8::Value>& info, const String& = "");
+bool initialize{{cpp_class}}({{cpp_class}}Init&, const Dictionary&, ExceptionState&, const v8::FunctionCallbackInfo<v8::Value>& info);
 
 {% endif %}
 } // namespace blink

third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.cpp

@@ -279,10 +279,10 @@ static const V8DOMConfiguration::AttributeConfiguration V8TestInterfaceEventCons
     {"deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttribute", TestInterfaceEventConstructorV8Internal::deprecatedImplementedAsInitializedByEventConstructorReadonlyStringAttributeAttributeGetterCallback, 0, 0, 0, 0, static_cast<v8::AccessControl>(v8::DEFAULT), static_cast<v8::PropertyAttribute>(v8::None), V8DOMConfiguration::ExposedToAllScripts, V8DOMConfiguration::OnInstance},
 };
 
-bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info, const String& forEventName)
+bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit& eventInit, const Dictionary& options, ExceptionState& exceptionState, const v8::FunctionCallbackInfo<v8::Value>& info)
 {
-    Dictionary::ConversionContext conversionContext(forEventName.isEmpty() ? String("TestInterfaceEventConstructor") : forEventName, "", exceptionState);
-    if (!initializeEvent(eventInit, options, exceptionState, info, forEventName.isEmpty() ? String("TestInterfaceEventConstructor") : forEventName))
+    Dictionary::ConversionContext conversionContext(exceptionState);
+    if (!initializeEvent(eventInit, options, exceptionState, info))
         return false;
 
     if (!DictionaryHelper::convert(options, conversionContext.setConversionType("DOMString", false), "initializedByEventConstructorReadonlyStringAttribute", eventInit.initializedByEventConstructorReadonlyStringAttribute))

third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventConstructor.h

@@ -47,7 +47,7 @@ public:
     static void installConditionallyEnabledMethods(v8::Handle<v8::Object>, v8::Isolate*) { }
 };
 
-bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit&, const Dictionary&, ExceptionState&, const v8::FunctionCallbackInfo<v8::Value>& info, const String& = "");
+bool initializeTestInterfaceEventConstructor(TestInterfaceEventConstructorInit&, const Dictionary&, ExceptionState&, const v8::FunctionCallbackInfo<v8::Value>& info);
 
 } // namespace blink