jankometer: Remove.

The histograms don't seem to be used anymore (do not show up in UMA). The
hang-detector and about:profiler produce relevant useful data for detecting jank.

BUG=none

Review URL: https://codereview.chromium.org/435603011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288117 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/browser_shutdown.cc

@@ -22,7 +22,6 @@
 #include "chrome/browser/about_flags.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/first_run/upgrade_util.h"
-#include "chrome/browser/jankometer.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/service_process/service_process_control.h"
@@ -192,8 +191,6 @@ bool ShutdownPreThreadsStop() {
 }
 
 void ShutdownPostThreadsStop(bool restart_last_session) {
-  // The jank'o'meter requires that the browser process has been destroyed
-  // before calling UninstallJankometer().
   delete g_browser_process;
   g_browser_process = NULL;
 
@@ -206,9 +203,6 @@ void ShutdownPostThreadsStop(bool restart_last_session) {
                                                         true);
 #endif
 
-  // Uninstall Jank-O-Meter here after the IO thread is no longer running.
-  UninstallJankometer();
-
 #if defined(OS_WIN)
   if (!browser_util::IsBrowserAlreadyRunning() &&
       shutdown_type_ != browser_shutdown::END_SESSION) {

chrome/browser/chrome_browser_main.cc

@@ -57,7 +57,6 @@
 #include "chrome/browser/google/google_search_counter.h"
 #include "chrome/browser/gpu/gl_string_manager.h"
 #include "chrome/browser/gpu/three_d_api_observer.h"
-#include "chrome/browser/jankometer.h"
 #include "chrome/browser/media/media_capture_devices_dispatcher.h"
 #include "chrome/browser/metrics/field_trial_synchronizer.h"
 #include "chrome/browser/metrics/thread_watcher.h"
@@ -1376,9 +1375,6 @@ int ChromeBrowserMainParts::PreMainMessageLoopRunImpl() {
     }
   }
 
-  if (parsed_command_line().HasSwitch(switches::kEnableWatchdog))
-    InstallJankometer(parsed_command_line());
-
 #if defined(ENABLE_FULL_PRINTING) && !defined(OFFICIAL_BUILD)
   if (parsed_command_line().HasSwitch(switches::kDebugPrint)) {
     base::FilePath path =

chrome/browser/chrome_content_browser_client.cc

@@ -1321,7 +1321,6 @@ void ChromeContentBrowserClient::AppendExtraCommandLineSwitches(
       switches::kEnableNetBenchmarking,
       switches::kEnableShowModalDialog,
       switches::kEnableStreamlinedHostedApps,
-      switches::kEnableWatchdog,
       switches::kEnableWebBasedSignin,
       switches::kMessageLoopHistogrammer,
       switches::kOutOfProcessPdf,

chrome/browser/jankometer.h

-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_JANKOMETER_H_
-#define CHROME_BROWSER_JANKOMETER_H_
-
-namespace base {
-class CommandLine;
-}
-
-// The Jank-O-Meter measures jankyness, which is user-perceivable lag in
-// responsiveness of the application.
-//
-// It will log such "lag" events to the metrics log.
-//
-// This function will initialize the service, which will install itself in
-// critical threads. It should be called on the UI thread.
-void InstallJankometer(const base::CommandLine& parsed_command_line);
-
-// Clean up Jank-O-Meter junk
-void UninstallJankometer();
-
-#endif  // CHROME_BROWSER_JANKOMETER_H_

chrome/browser/jankometer_stub.cc

-// Copyright (c) 2010 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/jankometer.h"
-
-// TODO(port): Implement jankometer
-// Mac: http://crbug.com/8077
-// Linux aura: http://crbug.com/358751
-void InstallJankometer(const base::CommandLine& parsed_command_line) {
-}
-
-void UninstallJankometer() {
-}

chrome/chrome_browser.gypi

@@ -642,8 +642,6 @@
       'browser/invalidation/profile_invalidation_provider_factory.h',
       'browser/io_thread.cc',
       'browser/io_thread.h',
-      'browser/jankometer.h',
-      'browser/jankometer_win.cc',
       'browser/jumplist_updater_win.cc',
       'browser/jumplist_updater_win.h',
       'browser/jumplist_win.cc',
@@ -2283,7 +2281,6 @@
       'browser/renderer_context_menu/spellchecker_submenu_observer_hunspell.cc',
     ],
     'chrome_browser_non_win_sources': [
-      'browser/jankometer_stub.cc',
       'browser/profiles/profile_shortcut_manager_stub.cc',
     ],
     # Desktop Linux and ChromeOS.

chrome/common/chrome_switches.cc

@@ -632,14 +632,6 @@ const char kEnableTranslateNewUX[]         = "enable-translate-new-ux";
 const char kEnableUserAlternateProtocolPorts[] =
     "enable-user-controlled-alternate-protocol-ports";
 
-// Spawns threads to watch for excessive delays in specified message loops.
-// User should set breakpoints on Alarm() to examine problematic thread.
-//
-// Usage:   -enable-watchdog=[ui][io]
-//
-// Order of the listed sub-arguments does not matter.
-const char kEnableWatchdog[]                = "enable-watchdog";
-
 // Uses WebSocket over SPDY.
 const char kEnableWebSocketOverSpdy[]       = "enable-websocket-over-spdy";
 

chrome/common/chrome_switches.h

@@ -184,7 +184,6 @@ extern const char kEnableSyncSyncedNotifications[];
 extern const char kEnableThumbnailRetargeting[];
 extern const char kEnableTranslateNewUX[];
 extern const char kEnableUserAlternateProtocolPorts[];
-extern const char kEnableWatchdog[];
 extern const char kEnableWebSocketOverSpdy[];
 extern const char kEnableWebsiteSettingsManager[];
 extern const char kEnhancedBookmarksExperiment[];

chrome/renderer/chrome_render_process_observer.cc

@@ -254,9 +254,6 @@ ChromeRenderProcessObserver::ChromeRenderProcessObserver(
       pending_cache_max_dead_capacity_(0),
       pending_cache_capacity_(kUnitializedCacheCapacity) {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
-  if (command_line.HasSwitch(switches::kEnableWatchdog)) {
-    // TODO(JAR): Need to implement renderer IO msgloop watchdog.
-  }
 
 #if defined(ENABLE_AUTOFILL_DIALOG)
   WebRuntimeFeatures::enableRequestAutocomplete(true);