Fix crash in SkiaOutputSurfaceImplOnGpu::ScheduleOverlays() on macOS

I think the problem is because the context lost or there is no gl
context. So GetOrCreateRenderPassOverlayBacking() cannot create a
shared image. Fix the problem by calling MakeCurrent() and check
the return value of GetOrCreateRenderPassOverlayBacking()


Bug: 1133797
Change-Id: Ibbb92c0c77a63903e2740eee099951b95b930053
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457468Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814845}

components/viz/service/display_embedder/skia_output_surface_impl_on_gpu.cc

@@ -988,6 +988,22 @@ void SkiaOutputSurfaceImplOnGpu::ScheduleOverlays(
     SkiaOutputSurface::OverlayList overlays,
     std::vector<ImageContextImpl*> image_contexts) {
 #if defined(OS_APPLE)
+  DCHECK(context_state_->GrContextIsGL());
+
+  // If |image_contexts| is not empty, it means there is at least one render
+  // pass overlays
+  bool has_render_pass_overlays =
+      !image_contexts.empty() ||
+      std::find_if(overlays.begin(), overlays.end(),
+                   [](const CALayerOverlay& overlay) {
+                     return !!overlay.ddl;
+                   }) != overlays.end();
+
+  // If there are render pass overlays, then a gl context is needed for drawing
+  // the overlay render passes to a backing for being scanned out.
+  if (has_render_pass_overlays && !MakeCurrent(false /* need_fbo0 */))
+    return;
+
   std::vector<GrBackendSemaphore> begin_semaphores;
   std::vector<GrBackendSemaphore> end_semaphores;
   promise_image_access_helper_.BeginAccess(std::move(image_contexts),
@@ -1007,6 +1023,8 @@ void SkiaOutputSurfaceImplOnGpu::ScheduleOverlays(
 
     const auto& characterization = overlay.ddl->characterization();
     auto backing = GetOrCreateRenderPassOverlayBacking(characterization);
+    if (!backing)
+      break;
     DCHECK(overlay.mailbox.IsZero());
     overlay.mailbox = backing->mailbox();
     auto scoped_access = backing->BeginScopedWriteAccess(
@@ -1558,6 +1576,7 @@ SkiaOutputSurfaceImplOnGpu::GetOrCreateRenderPassOverlayBacking(
       kOverlayUsage);
   if (!result) {
     LOG(ERROR) << "CreateSharedImage() failed.";
+    MarkContextLost(CONTEXT_LOST_OUT_OF_MEMORY);
     return nullptr;
   }