Commit 8060beb7 authored by Andrei Chulkov's avatar Andrei Chulkov Committed by Commit Bot

Final versions of strings for password manager onboarding

This CL sets the final version the title, explanation and button strings
for the password manager onboarding dialog.

Bug: 983445
Change-Id: Ibc265894f04877be5f89676e295fa7a7d6c37cc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781638Reviewed-by: default avatarIoana Pandele <ioanap@chromium.org>
Commit-Queue: Andrei Chulkov <achulkov@google.com>
Cr-Commit-Position: refs/heads/master@{#693791}
parent f97cfa26
...@@ -63,7 +63,7 @@ public class OnboardingDialogBridge { ...@@ -63,7 +63,7 @@ public class OnboardingDialogBridge {
public void showDialog(String onboardingTitle, String onboardingDetails) { public void showDialog(String onboardingTitle, String onboardingDetails) {
mOnboardingDialog.showDialog(onboardingTitle, onboardingDetails, mOnboardingDialog.showDialog(onboardingTitle, onboardingDetails,
getDrawableResourceFromFeature(), mResources.getString(R.string.continue_button), getDrawableResourceFromFeature(), mResources.getString(R.string.continue_button),
mResources.getString(R.string.cancel), this::onClick, true); mResources.getString(R.string.not_now), this::onClick, true);
} }
@CalledByNative @CalledByNative
......
...@@ -155,6 +155,9 @@ CHAR-LIMIT guidelines: ...@@ -155,6 +155,9 @@ CHAR-LIMIT guidelines:
<message name="IDS_CANCEL" desc="Label for a cancel button. Used in multiple contexts. [CHAR-LIMIT=20]"> <message name="IDS_CANCEL" desc="Label for a cancel button. Used in multiple contexts. [CHAR-LIMIT=20]">
Cancel Cancel
</message> </message>
<message name="IDS_NOT_NOW" desc="Label for a not now button. Used in multiple contexts. [CHAR-LIMIT=20]">
Not now
</message>
<message name="IDS_SAVE" desc="Label for a button to save a change. Used in multiple contexts. [CHAR-LIMIT=20]"> <message name="IDS_SAVE" desc="Label for a button to save a change. Used in multiple contexts. [CHAR-LIMIT=20]">
Save Save
</message> </message>
......
...@@ -317,14 +317,8 @@ Chromium is unable to recover your settings. ...@@ -317,14 +317,8 @@ Chromium is unable to recover your settings.
Chromium will save this password in your Google Account. You won’t have to remember it. Chromium will save this password in your Google Account. You won’t have to remember it.
</message> </message>
<!-- Password manager onboarding strings --> <!-- Password manager onboarding strings -->
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_A" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Chromium can help you remember your passwords so you don't have to.
</message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_B" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Save your passwords to Chromium to access them on all your devices.
</message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_C" desc="The explanation text that is shown below the title in the password manager onboarding dialog."> <message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_C" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Chromium can help you remember your passwords so you don't have to. Chromium lets you know if your passwords are ever compromised
</message> </message>
<message name="IDS_PASSWORD_MANAGER_TITLE_BRAND" desc="The product name used in the title of the password bubble."> <message name="IDS_PASSWORD_MANAGER_TITLE_BRAND" desc="The product name used in the title of the password bubble.">
Chromium Chromium
......
...@@ -4602,10 +4602,16 @@ Keep your key file in a safe place. You will need it to create new versions of y ...@@ -4602,10 +4602,16 @@ Keep your key file in a safe place. You will need it to create new versions of y
Save your passwords? Save your passwords?
</message> </message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_TITLE_B" desc="The title shown in the password manager onboarding dialog."> <message name="IDS_PASSWORD_MANAGER_ONBOARDING_TITLE_B" desc="The title shown in the password manager onboarding dialog.">
Access your passwords everywhere Store once. Use everywhere
</message> </message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_TITLE_C" desc="The title shown in the password manager onboarding dialog."> <message name="IDS_PASSWORD_MANAGER_ONBOARDING_TITLE_C" desc="The title shown in the password manager onboarding dialog.">
Securely remember your passwords Never worry about your passwords
</message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_A" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Save passwords securely in your Google Account, and you'll never have to type them again
</message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_B" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Access your passwords whenever you're signed in to your Google Account
</message> </message>
<!-- Begin of Sync Promo strings for Desktop Identity Consistency. --> <!-- Begin of Sync Promo strings for Desktop Identity Consistency. -->
......
...@@ -328,14 +328,8 @@ Google Chrome is unable to recover your settings. ...@@ -328,14 +328,8 @@ Google Chrome is unable to recover your settings.
Chrome will save this password in your Google Account. You won’t have to remember it. Chrome will save this password in your Google Account. You won’t have to remember it.
</message> </message>
<!-- Password manager onboarding strings --> <!-- Password manager onboarding strings -->
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_A" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Chrome can help you remember your passwords so you don't have to.
</message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_B" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Save your passwords to Chrome to access them on all your devices.
</message>
<message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_C" desc="The explanation text that is shown below the title in the password manager onboarding dialog."> <message name="IDS_PASSWORD_MANAGER_ONBOARDING_DETAILS_C" desc="The explanation text that is shown below the title in the password manager onboarding dialog.">
Chrome can help you remember your passwords so you don't have to. Chrome lets you know if your passwords are ever compromised
</message> </message>
<message name="IDS_PASSWORD_MANAGER_TITLE_BRAND" desc="The product name used in the title of the password bubble."> <message name="IDS_PASSWORD_MANAGER_TITLE_BRAND" desc="The product name used in the title of the password bubble.">
Google Chrome Google Chrome
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment