Commit 808291f0 authored by Rob Buis's avatar Rob Buis Committed by Commit Bot

Make createHTMLDocument return a Document

As the FIXME says, instead of a HTMLDocument
we should return a plain Document:
https://dom.spec.whatwg.org/#domimplementation

Bug: 238368
Change-Id: I3dd9bf5039994ef0a98863dc0b4d4dffae23453d
Reviewed-on: https://chromium-review.googlesource.com/669459
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502867}
parent a5b83980
...@@ -201,7 +201,7 @@ bool DOMImplementation::IsTextMIMEType(const String& mime_type) { ...@@ -201,7 +201,7 @@ bool DOMImplementation::IsTextMIMEType(const String& mime_type) {
IsJSONMIMEType(mime_type) || IsTextPlainType(mime_type); IsJSONMIMEType(mime_type) || IsTextPlainType(mime_type);
} }
HTMLDocument* DOMImplementation::createHTMLDocument(const String& title) { Document* DOMImplementation::createHTMLDocument(const String& title) {
DocumentInit init = DocumentInit init =
DocumentInit::Create() DocumentInit::Create()
.WithContextDocument(document_->ContextDocument()) .WithContextDocument(document_->ContextDocument())
......
...@@ -33,7 +33,6 @@ class Document; ...@@ -33,7 +33,6 @@ class Document;
class DocumentInit; class DocumentInit;
class DocumentType; class DocumentType;
class ExceptionState; class ExceptionState;
class HTMLDocument;
class XMLDocument; class XMLDocument;
class CORE_EXPORT DOMImplementation final class CORE_EXPORT DOMImplementation final
...@@ -58,7 +57,7 @@ class CORE_EXPORT DOMImplementation final ...@@ -58,7 +57,7 @@ class CORE_EXPORT DOMImplementation final
ExceptionState&); ExceptionState&);
// From the HTMLDOMImplementation interface // From the HTMLDOMImplementation interface
HTMLDocument* createHTMLDocument(const String& title = String()); Document* createHTMLDocument(const String& title = String());
// Other methods (not part of DOM) // Other methods (not part of DOM)
static Document* createDocument(const String& mime_type, static Document* createDocument(const String& mime_type,
......
...@@ -26,7 +26,7 @@ ...@@ -26,7 +26,7 @@
[NewObject, RaisesException] DocumentType createDocumentType(DOMString qualifiedName, DOMString publicId, DOMString systemId); [NewObject, RaisesException] DocumentType createDocumentType(DOMString qualifiedName, DOMString publicId, DOMString systemId);
[NewObject, RaisesException] XMLDocument createDocument(DOMString? namespaceURI, [TreatNullAs=EmptyString] DOMString qualifiedName, optional DocumentType? doctype = null); [NewObject, RaisesException] XMLDocument createDocument(DOMString? namespaceURI, [TreatNullAs=EmptyString] DOMString qualifiedName, optional DocumentType? doctype = null);
// FIXME: createHTMLDocument should return a Document. crbug.com/238368 // FIXME: createHTMLDocument should return a Document. crbug.com/238368
[NewObject] HTMLDocument createHTMLDocument(optional DOMString title); [NewObject] Document createHTMLDocument(optional DOMString title);
// useless; always returns true // useless; always returns true
boolean hasFeature(); boolean hasFeature();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment