Commit 8083b4bf authored by James Hawkins's avatar James Hawkins Committed by Commit Bot

Smart Lock: Delete ClearPermitAccess and related.

This value is no longer set or read.

Bug: none
Test: none
Change-Id: I53c4d95c0341bcfcca23b39706cd89971f8c2983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929919
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Auto-Submit: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#718720}
parent bbabdef4
...@@ -82,9 +82,6 @@ class EasyUnlockService : public KeyedService { ...@@ -82,9 +82,6 @@ class EasyUnlockService : public KeyedService {
// Returns the user currently associated with the service. // Returns the user currently associated with the service.
virtual AccountId GetAccountId() const = 0; virtual AccountId GetAccountId() const = 0;
// Gets/Sets/Clears the permit access for the local device.
virtual void ClearPermitAccess() = 0;
// Retrieve the stored remote devices list: // Retrieve the stored remote devices list:
// * If in regular context, device list is retrieved from prefs. // * If in regular context, device list is retrieved from prefs.
// * If in sign-in context, device list is retrieved from TPM. // * If in sign-in context, device list is retrieved from TPM.
......
...@@ -60,9 +60,6 @@ namespace chromeos { ...@@ -60,9 +60,6 @@ namespace chromeos {
namespace { namespace {
// Key name of the local device permit record dictonary in kEasyUnlockPairing.
const char kKeyPermitAccess[] = "permitAccess";
// Key name of the remote device list in kEasyUnlockPairing. // Key name of the remote device list in kEasyUnlockPairing.
const char kKeyDevices[] = "devices"; const char kKeyDevices[] = "devices";
...@@ -292,12 +289,6 @@ AccountId EasyUnlockServiceRegular::GetAccountId() const { ...@@ -292,12 +289,6 @@ AccountId EasyUnlockServiceRegular::GetAccountId() const {
return primary_user->GetAccountId(); return primary_user->GetAccountId();
} }
void EasyUnlockServiceRegular::ClearPermitAccess() {
DictionaryPrefUpdate pairing_update(profile()->GetPrefs(),
prefs::kEasyUnlockPairing);
pairing_update->RemoveWithoutPathExpansion(kKeyPermitAccess, NULL);
}
const base::ListValue* EasyUnlockServiceRegular::GetRemoteDevices() const { const base::ListValue* EasyUnlockServiceRegular::GetRemoteDevices() const {
const base::DictionaryValue* pairing_dict = const base::DictionaryValue* pairing_dict =
profile()->GetPrefs()->GetDictionary(prefs::kEasyUnlockPairing); profile()->GetPrefs()->GetDictionary(prefs::kEasyUnlockPairing);
...@@ -459,9 +450,6 @@ void EasyUnlockServiceRegular::ShowChromebookAddedNotification() { ...@@ -459,9 +450,6 @@ void EasyUnlockServiceRegular::ShowChromebookAddedNotification() {
void EasyUnlockServiceRegular::ShowNotificationIfNewDevicePresent( void EasyUnlockServiceRegular::ShowNotificationIfNewDevicePresent(
const std::set<std::string>& public_keys_before_sync, const std::set<std::string>& public_keys_before_sync,
const std::set<std::string>& public_keys_after_sync) { const std::set<std::string>& public_keys_after_sync) {
if (public_keys_after_sync.empty())
ClearPermitAccess();
if (public_keys_before_sync == public_keys_after_sync) if (public_keys_before_sync == public_keys_after_sync)
return; return;
......
...@@ -84,7 +84,6 @@ class EasyUnlockServiceRegular ...@@ -84,7 +84,6 @@ class EasyUnlockServiceRegular
override; override;
EasyUnlockService::Type GetType() const override; EasyUnlockService::Type GetType() const override;
AccountId GetAccountId() const override; AccountId GetAccountId() const override;
void ClearPermitAccess() override;
const base::ListValue* GetRemoteDevices() const override; const base::ListValue* GetRemoteDevices() const override;
std::string GetChallenge() const override; std::string GetChallenge() const override;
std::string GetWrappedSecret() const override; std::string GetWrappedSecret() const override;
......
...@@ -227,10 +227,6 @@ AccountId EasyUnlockServiceSignin::GetAccountId() const { ...@@ -227,10 +227,6 @@ AccountId EasyUnlockServiceSignin::GetAccountId() const {
return account_id_; return account_id_;
} }
void EasyUnlockServiceSignin::ClearPermitAccess() {
NOTREACHED();
}
const base::ListValue* EasyUnlockServiceSignin::GetRemoteDevices() const { const base::ListValue* EasyUnlockServiceSignin::GetRemoteDevices() const {
const UserData* data = FindLoadedDataForCurrentUser(); const UserData* data = FindLoadedDataForCurrentUser();
if (!data) if (!data)
......
...@@ -90,7 +90,6 @@ class EasyUnlockServiceSignin ...@@ -90,7 +90,6 @@ class EasyUnlockServiceSignin
override; override;
EasyUnlockService::Type GetType() const override; EasyUnlockService::Type GetType() const override;
AccountId GetAccountId() const override; AccountId GetAccountId() const override;
void ClearPermitAccess() override;
const base::ListValue* GetRemoteDevices() const override; const base::ListValue* GetRemoteDevices() const override;
std::string GetChallenge() const override; std::string GetChallenge() const override;
std::string GetWrappedSecret() const override; std::string GetWrappedSecret() const override;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment