Commit 808bbedf authored by Dominic Battre's avatar Dominic Battre Committed by Commit Bot

Enable AutofillRejectCompanyBirthyear and AutofillServerBehaviors

This CL enables the two experiments in fieldtrial_testing_config.json.

Bug: 956560
Change-Id: I82940976641e32b53671a4bb46d4363b71f35fc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985014Reviewed-by: default avatarMatthias Körber <koerber@google.com>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728018}
parent a8014449
...@@ -731,7 +731,8 @@ class AutofillInteractiveTestWithHistogramTester ...@@ -731,7 +731,8 @@ class AutofillInteractiveTestWithHistogramTester
// Only allow requests to be loaded that are necessary for the test. This // Only allow requests to be loaded that are necessary for the test. This
// allows a histogram to test properties of some specific requests. // allows a histogram to test properties of some specific requests.
std::vector<std::string> allowlist = { std::vector<std::string> allowlist = {
"/internal/test_url_path", "https://clients1.google.com/tbproxy"}; "/internal/test_url_path", "https://clients1.google.com/tbproxy",
"https://content-autofill.googleapis.com/"};
url_loader_interceptor_ = url_loader_interceptor_ =
std::make_unique<URLLoaderInterceptor>(base::BindLambdaForTesting( std::make_unique<URLLoaderInterceptor>(base::BindLambdaForTesting(
[&](URLLoaderInterceptor::RequestParams* params) { [&](URLLoaderInterceptor::RequestParams* params) {
...@@ -780,6 +781,8 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTestWithHistogramTester, ...@@ -780,6 +781,8 @@ IN_PROC_BROWSER_TEST_F(AutofillInteractiveTestWithHistogramTester,
// Assert that the network isolation key is populated for 2 requests: // Assert that the network isolation key is populated for 2 requests:
// - Navigation: /internal/test_url_path // - Navigation: /internal/test_url_path
// - Autofill query: https://clients1.google.com/tbproxy/af/query?... // - Autofill query: https://clients1.google.com/tbproxy/af/query?...
// or "https://content-autofill.googleapis.com/..." (depending on the
// finch configuration of the AutofillUseApi feature).
histogram_tester().ExpectBucketCount("HttpCache.NetworkIsolationKeyPresent2", histogram_tester().ExpectBucketCount("HttpCache.NetworkIsolationKeyPresent2",
2 /*kPresent*/, 2 /*count*/); 2 /*kPresent*/, 2 /*count*/);
} }
......
...@@ -771,7 +771,7 @@ ...@@ -771,7 +771,7 @@
] ]
} }
], ],
"AutofillDynamicForms": [ "AutofillCompany": [
{ {
"platforms": [ "platforms": [
"android", "android",
...@@ -783,15 +783,16 @@ ...@@ -783,15 +783,16 @@
], ],
"experiments": [ "experiments": [
{ {
"name": "FullLaunch", "name": "RejectBirthyearAsCompany",
"enable_features": [ "enable_features": [
"AutofillDynamicForms" "AutofillEnableCompanyName",
"AutofillRejectCompanyBirthyear"
] ]
} }
] ]
} }
], ],
"AutofillEnableCompanyName": [ "AutofillDynamicForms": [
{ {
"platforms": [ "platforms": [
"android", "android",
...@@ -803,9 +804,9 @@ ...@@ -803,9 +804,9 @@
], ],
"experiments": [ "experiments": [
{ {
"name": "Disabled", "name": "FullLaunch",
"disable_features": [ "enable_features": [
"AutofillEnableCompanyName" "AutofillDynamicForms"
] ]
} }
] ]
...@@ -1018,7 +1019,7 @@ ...@@ -1018,7 +1019,7 @@
] ]
} }
], ],
"AutofillRejectCompanyBirthyear": [ "AutofillServerBehaviors": [
{ {
"platforms": [ "platforms": [
"android", "android",
...@@ -1030,9 +1031,13 @@ ...@@ -1030,9 +1031,13 @@
], ],
"experiments": [ "experiments": [
{ {
"name": "Enabled", "name": "API_Enabled",
"params": {
"autofill-server-url": "https://content-autofill.googleapis.com/"
},
"enable_features": [ "enable_features": [
"AutofillRejectCompanyBirthyear" "AutofillServerCommunication",
"AutofillUseApi"
] ]
} }
] ]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment