[chrome://omnibox] [omnibox] Handle leading whitespace in inputText.

The debug page compares response and request inputTexts to prevent async
responses for old requests from being shown. This comparison did not
consider that responses' inputTexts are trimmed of whitespace.

This CL likewise trims the requests' inputTexts when comparing the two.

Bug: 1045343
Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9

NOTRY=true
To skip android-binary-size bot due to a bug (crbug.com/1045024).
Other try-bots have passed.

Change-Id: I0e0553fcb2c6d9c21cd5c10194b769120824b6a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019927
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735408}

chrome/browser/resources/omnibox/omnibox.js

@@ -86,19 +86,13 @@ class BrowserProxy {
     this.lastRequest;
   }
 
-
   /**
    * @param {!mojom.OmniboxResponse} response
    * @param {boolean} isPageController
    */
   handleNewAutocompleteResponse(response, isPageController) {
-    // Note: Using inputText is a sufficient fix for the way this is used today,
-    // but in principle it would be better to associate requests with responses
-    // using a unique session identifier, for example by rolling an integer each
-    // time a request is made. Doing so would require extra bookkeeping on the
-    // host side, so for now we keep it simple.
-    const isForLastPageRequest = isPageController && this.lastRequest &&
-        this.lastRequest.inputText === response.inputText;
+    const isForLastPageRequest =
+        this.isForLastPageRequest(response.inputText, isPageController);
 
     // When unfocusing the browser omnibox, the autocomplete controller
     // sends a response with no combined results. This response is ignored
@@ -127,8 +121,7 @@ class BrowserProxy {
   handleNewAutocompleteQuery(isPageController, inputText) {
     // If the request originated from the debug page and is not for display,
     // then we don't want to clear the omniboxOutput.
-    if (isPageController && this.lastRequest &&
-            this.lastRequest.inputText === inputText &&
+    if (this.isForLastPageRequest(inputText, isPageController) &&
             this.lastRequest.display ||
         omniboxInput.connectWindowOmnibox && !isPageController) {
       omniboxOutput.prepareNewQuery();
@@ -159,6 +152,21 @@ class BrowserProxy {
           pageClassification);
     });
   }
+
+  /**
+   * @param {string} inputText
+   * @param {boolean} isPageController
+   * @return {boolean}
+   */
+  isForLastPageRequest(inputText, isPageController) {
+    // Note: Using inputText is a sufficient fix for the way this is used today,
+    // but in principle it would be better to associate requests with responses
+    // using a unique session identifier, for example by rolling an integer each
+    // time a request is made. Doing so would require extra bookkeeping on the
+    // host side, so for now we keep it simple.
+    return isPageController && this.lastRequest !== null &&
+        this.lastRequest.inputText.trim() === inputText;
+  }
 }
 
 document.addEventListener('DOMContentLoaded', () => {