Skip to content

GitLab

T
tangled
Commit 80aae53b authored by Trent Apted's avatar Trent Apted Committed by Commit Bot
Browse files
Options

Gallery: closure compile dimmable_ui_controller_unittest.js 

This one was straightforward. The deleted .html harness had a mock for
ContentMetadataProvider and some chrome.* stuff. However it appears to
be unnecessary: neither the test, nor dimmable_ui_controller.js itself
use these.

Bug: 867700
Change-Id: Iec0bbe7d7126e7dcf8eaffe5f189c0655e6a2e74
Reviewed-on: https://chromium-review.googlesource.com/1171971
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582496}
parent 0ef1727a
Hide whitespace changes
Inline Side-by-side
Showing with 13 additions and 31 deletions
chrome/browser/chromeos/file_manager/gallery_jstest.cc
View file @ 80aae53b
...@@ -56,6 +56,5 @@ IN_PROC_BROWSER_TEST_F(GalleryJsTest, SlideModeTest) { ...@@ -56,6 +56,5 @@ IN_PROC_BROWSER_TEST_F(GalleryJsTest, SlideModeTest) {
} }
IN_PROC_BROWSER_TEST_F(GalleryJsTest, DimmableUIControllerTest) { IN_PROC_BROWSER_TEST_F(GalleryJsTest, DimmableUIControllerTest) {
RunTest(base::FilePath( RunGeneratedTest("/dimmable_ui_controller_unittest.html");
FILE_PATH_LITERAL("dimmable_ui_controller_unittest.html")));
} }
ui/file_manager/gallery/js/BUILD.gn
View file @ 80aae53b
...@@ -37,6 +37,17 @@ js_library("dimmable_ui_controller") { ...@@ -37,6 +37,17 @@ js_library("dimmable_ui_controller") {
"image_editor:image_editor_prompt", "image_editor:image_editor_prompt",
"//ui/webui/resources/js:assert", "//ui/webui/resources/js:assert",
] ]
externs_list = [
"$externs_path/chrome.js",
"$externs_path/chrome_extensions.js", # For chrome.accessibilityFeatures.
]
}
js_library("dimmable_ui_controller_unittest") {
deps = [
":dimmable_ui_controller",
"//ui/webui/resources/js:webui_resource_test",
]
} }
js_library("entry_list_watcher") { js_library("entry_list_watcher") {
...@@ -170,6 +181,7 @@ js_library("thumbnail_mode") { ...@@ -170,6 +181,7 @@ js_library("thumbnail_mode") {
js_unit_tests("unit_tests") { js_unit_tests("unit_tests") {
deps = [ deps = [
":dimmable_ui_controller_unittest",
":gallery_util_unittest", ":gallery_util_unittest",
":ribbon_unittest", ":ribbon_unittest",
] ]
......
ui/file_manager/gallery/js/dimmable_ui_controller_unittest.html deleted 100644 → 0
View file @ 0ef1727a
<!DOCTYPE html>
<!-- Copyright 2015 The Chromium Authors. All rights reserved.
-- Use of this source code is governed by a BSD-style license that can be
-- found in the LICENSE file.
-->
<script type="text/javascript">
var ContentMetadataProvider = {};
var chrome = {
fileManagerPrivate: {
getStrings: function(/* ignore */) {}
},
runtime: {
getBackgroundPage: function(/* ignore */) {}
}
};
</script>
<script src="../../../webui/resources/js/cr.js"></script>
<script src="../../../webui/resources/js/cr/event_target.js"></script>
<script src="../../../webui/resources/js/cr/ui/array_data_model.js"></script>
<script src="../../file_manager/common/js/async_util.js"></script>
<script src="../../file_manager/foreground/js/volume_manager_wrapper.js"></script>
<script src="gallery.js"></script>
<script src="gallery_constants.js"></script>
<script src="dimmable_ui_controller.js"></script>
<script src="dimmable_ui_controller_unittest.js"></script>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment