Stop recording "Profile destruction" bucket of Sync.StopSource

It was never accurate: It was recorded during most profile destructions,
even if Sync was never enabled in the first place. Since I'm not aware
of anything that depends on this number, let's just get rid of it rather
than replace it with something that works.

Bug: none
Change-Id: I397e499f559852188c731c04cbb748f98a69fe24
Reviewed-on: https://chromium-review.googlesource.com/1117068Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570785}

chrome/browser/profiles/profile_manager.cc

@@ -1552,20 +1552,11 @@ void ProfileManager::OnLoadProfileForProfileDeletion(
         content::NotificationService::NoDetails());
 
     // Disable sync for doomed profile.
-    if (ProfileSyncServiceFactory::GetInstance()->HasProfileSyncService(
-            profile)) {
+    if (ProfileSyncServiceFactory::HasProfileSyncService(profile)) {
       browser_sync::ProfileSyncService* sync_service =
-          ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile);
-      if (sync_service->IsSyncRequested()) {
-        // Record sync stopped by profile destruction if it was on before.
-        UMA_HISTOGRAM_ENUMERATION("Sync.StopSource",
-                                  syncer::PROFILE_DESTRUCTION,
-                                  syncer::STOP_SOURCE_LIMIT);
-      }
+          ProfileSyncServiceFactory::GetForProfile(profile);
       // Ensure data is cleared even if sync was already off.
-      ProfileSyncServiceFactory::GetInstance()
-          ->GetForProfile(profile)
-          ->RequestStop(browser_sync::ProfileSyncService::CLEAR_DATA);
+      sync_service->RequestStop(browser_sync::ProfileSyncService::CLEAR_DATA);
     }
 
     ProfileAttributesEntry* entry;

tools/metrics/histograms/enums.xml

@@ -45052,7 +45052,11 @@ would be helpful to identify which type is being sent.
 </enum>
 
 <enum name="SyncStopSource">
-  <int value="0" label="Profile destruction"/>
+  <int value="0" label="DEPRECATED 2018-06 Profile destruction">
+    Supposedly meant that Sync was stopped due to the profile being destroyed.
+    However, it was recorded during most profile destructions, even if Sync was
+    never enabled in the first place. We stopped recording this in 2018-06.
+  </int>
   <int value="1" label="Sign out"/>
   <int value="2" label="Birthday error"/>
   <int value="3" label="Chrome sync settings"/>