cros_healthd: add kNotRun diagnostic routine status enum

This enum represents a routine state where the routine was not run
because it is not currently applicatble to the device.  e.g. Secure WiFi
test when the device is not connected to WiFi.

Bug: b:173063870
Change-Id: I0899c284fc51f3878e468e3aff1b6fadbf6ae7c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537776Reviewed-by: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Trent Begin <tbegin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827399}

chromeos/components/diagnostics_ui/backend/system_routine_controller.cc

@@ -47,6 +47,7 @@ mojom::StandardRoutineResult TestStatusToResult(
       return mojom::StandardRoutineResult::kExecutionError;
     case healthd::DiagnosticRoutineStatusEnum::kFailedToStart:
     case healthd::DiagnosticRoutineStatusEnum::kUnsupported:
+    case healthd::DiagnosticRoutineStatusEnum::kNotRun:
       return mojom::StandardRoutineResult::kUnableToRun;
     case healthd::DiagnosticRoutineStatusEnum::kReady:
     case healthd::DiagnosticRoutineStatusEnum::kRunning:

chromeos/components/telemetry_extension_ui/diagnostics_service_converters.cc

@@ -154,6 +154,8 @@ health::mojom::DiagnosticRoutineStatusEnum Convert(
       return health::mojom::DiagnosticRoutineStatusEnum::kCancelling;
     case cros_healthd::mojom::DiagnosticRoutineStatusEnum::kUnsupported:
       return health::mojom::DiagnosticRoutineStatusEnum::kUnsupported;
+    case cros_healthd::mojom::DiagnosticRoutineStatusEnum::kNotRun:
+      return health::mojom::DiagnosticRoutineStatusEnum::kNotRun;
   }
   NOTREACHED();
   return static_cast<health::mojom::DiagnosticRoutineStatusEnum>(

chromeos/components/telemetry_extension_ui/diagnostics_service_converters_unittest.cc

@@ -37,6 +37,8 @@ TEST(DiagnosticsServiceConvertersTest, ConvertDiagnosticRoutineStatusEnum) {
             health::DiagnosticRoutineStatusEnum::kCancelling);
   EXPECT_EQ(Convert(cros_healthd::DiagnosticRoutineStatusEnum::kUnsupported),
             health::DiagnosticRoutineStatusEnum::kUnsupported);
+  EXPECT_EQ(Convert(cros_healthd::DiagnosticRoutineStatusEnum::kNotRun),
+            health::DiagnosticRoutineStatusEnum::kNotRun);
 }
 
 TEST(DiagnosticsServiceConvertersTest,

chromeos/components/telemetry_extension_ui/mojom/diagnostics_service.mojom

@@ -286,6 +286,7 @@ enum DiagnosticRoutineStatusEnum {
   kRemoved = 8,  // Routine has been removed and is no longer valid.
   kCancelling = 9,  // Routine is in the process of being cancelled.
   kUnsupported = 10,  // Routine is not supported by the device.
+  kNotRun = 11,  // Routine was not run because it is currently not applicable.
 };
 
 // Enumeration of each of the messages a diagnostics routine can pass back.

chromeos/components/telemetry_extension_ui/resources/trusted.js

@@ -120,6 +120,7 @@ class DiagnosticsProxy {
       [statusEnum.kRemoved, 'removed'],
       [statusEnum.kCancelling, 'cancelling'],
       [statusEnum.kUnsupported, 'unsupported'],
+      [statusEnum.kNotRun, 'not-run'],
     ]);
 
     if (this.enumToStatus_.size !== statusEnum.MAX_VALUE + 1) {

chromeos/components/telemetry_extension_ui/test/telemetry_extension_ui_browsertest.js

@@ -103,6 +103,8 @@ TEST_F('TelemetryExtensionUIBrowserTest', 'ConvertDiagnosticsEnums', () => {
       diagnosticsProxy.convertStatus(statusEnum.kCancelling), 'cancelling');
   assertEquals(
       diagnosticsProxy.convertStatus(statusEnum.kUnsupported), 'unsupported');
+  assertEquals(
+      diagnosticsProxy.convertStatus(statusEnum.kNotRun), 'not-run');
 
   // Unit tests for convertUserMessage
   const userMessageEnum =

chromeos/services/cros_healthd/public/mojom/cros_healthd_diagnostics.mojom

@@ -64,6 +64,7 @@ enum DiagnosticRoutineStatusEnum {
   kRemoved = 8,  // Routine has been removed and is no longer valid.
   kCancelling = 9,  // Routine is in the process of being cancelled.
   kUnsupported = 10,  // Routine is not supported by the device.
+  kNotRun = 11,  // Routine was not run because it is currently not applicable.
 };
 
 // Enumeration of each of the messages a diagnostics routine can pass back.