[FragmentItem] Fix resolved direction for box items

This patch fixes resolved direction for box items. Before
this patch, it was set to the opposite direction.

Bug: 982194
Change-Id: I1fcdd0c15fa453ac8a25ba6cc81769022cbfd2f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880895
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709767}

third_party/blink/renderer/core/layout/ng/inline/ng_fragment_item.cc

@@ -39,16 +39,15 @@ NGFragmentItem::NGFragmentItem(const NGPhysicalLineBoxFragment& line,
       text_direction_(static_cast<unsigned>(line.BaseDirection())) {}
 
 NGFragmentItem::NGFragmentItem(const NGPhysicalBoxFragment& box,
-                               wtf_size_t item_count)
+                               wtf_size_t item_count,
+                               TextDirection resolved_direction)
     : layout_object_(box.GetLayoutObject()),
       box_({&box, item_count}),
       rect_({PhysicalOffset(), box.Size()}),
       type_(kBox),
       style_variant_(static_cast<unsigned>(box.StyleVariant())),
       is_hidden_for_paint_(false),
-      // TODO(yosin): We should have |textDirection| parameter from
-      // |NGLineBoxFragmentBuilder::Child::BidiLevel()|
-      text_direction_(box.IsAtomicInline() && IsLtr(box.ResolvedDirection())) {}
+      text_direction_(static_cast<unsigned>(resolved_direction)) {}
 
 NGFragmentItem::~NGFragmentItem() {
   switch (Type()) {

third_party/blink/renderer/core/layout/ng/inline/ng_fragment_item.h

@@ -62,7 +62,9 @@ class CORE_EXPORT NGFragmentItem : public DisplayItemClient {
 
   // TODO(kojii): Should be able to create without once creating fragments.
   NGFragmentItem(const NGPhysicalTextFragment& text);
-  NGFragmentItem(const NGPhysicalBoxFragment& box, wtf_size_t item_count);
+  NGFragmentItem(const NGPhysicalBoxFragment& box,
+                 wtf_size_t item_count,
+                 TextDirection resolved_direction);
   NGFragmentItem(const NGPhysicalLineBoxFragment& line, wtf_size_t item_count);
 
   ~NGFragmentItem() final;

third_party/blink/renderer/core/layout/ng/inline/ng_fragment_items_builder.cc

@@ -85,7 +85,9 @@ void NGFragmentItemsBuilder::AddItems(Child* child_begin, Child* child_end) {
         if (!has_floating_descendants_for_paint_ && box.IsFloating())
           has_floating_descendants_for_paint_ = true;
 
-        items_.push_back(std::make_unique<NGFragmentItem>(box, 1));
+        DCHECK(child.HasBidiLevel());
+        items_.push_back(std::make_unique<NGFragmentItem>(
+            box, 1, DirectionFromLevel(child.bidi_level)));
         offsets_.push_back(child.offset);
         ++child_iter;
         continue;
@@ -112,8 +114,9 @@ void NGFragmentItemsBuilder::AddItems(Child* child_begin, Child* child_end) {
       wtf_size_t item_count = items_.size() - box_start_index;
 
       // Create an item for the start of the box.
-      items_[box_start_index] =
-          std::make_unique<NGFragmentItem>(box, item_count);
+      DCHECK(child.HasBidiLevel());
+      items_[box_start_index] = std::make_unique<NGFragmentItem>(
+          box, item_count, DirectionFromLevel(child.bidi_level));
       continue;
     }
 
@@ -127,7 +130,11 @@ void NGFragmentItemsBuilder::AddItems(Child* child_begin, Child* child_end) {
 void NGFragmentItemsBuilder::AddListMarker(
     const NGPhysicalBoxFragment& marker_fragment,
     const LogicalOffset& offset) {
-  items_.push_back(std::make_unique<NGFragmentItem>(marker_fragment, 1));
+  // Resolved direction matters only for inline items, and outside list markers
+  // are not inline.
+  const TextDirection resolved_direction = TextDirection::kLtr;
+  items_.push_back(
+      std::make_unique<NGFragmentItem>(marker_fragment, 1, resolved_direction));
   offsets_.push_back(offset);
 }