Remove non-app-window URLs from feedback page

Currently three links from feedback form don't work properly on login
screen, by opening invisible incognito windows only. This CL removes
the links until the problem can be fixed on login screen.

screen and click on the links for privacy/terms of service. Nothing is
expected to happen, the links are disabled.

Bug: chromium:1116383
TEST: Manually verified on device by pressing alt+shift+I on login
Change-Id: Ieffd4cccbc8fbac52f45890761783cadb29cd3ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362797
Commit-Queue: Igor <igorcov@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Roland Bock <rbock@google.com>
Auto-Submit: Igor <igorcov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800531}

chrome/browser/resources/feedback/js/feedback.js

@@ -512,67 +512,71 @@ function initialize() {
               true /* useAppWindow */);
         }
 
-        const legalHelpPageUrlElement = $('legal-help-page-url');
-        if (legalHelpPageUrlElement) {
-          setupLinkHandlers(
-              legalHelpPageUrlElement, FEEDBACK_LEGAL_HELP_URL,
-              false /* useAppWindow */);
-        }
-
-        const privacyPolicyUrlElement = $('privacy-policy-url');
-        if (privacyPolicyUrlElement) {
-          setupLinkHandlers(
-              privacyPolicyUrlElement, FEEDBACK_PRIVACY_POLICY_URL,
-              false /* useAppWindow */);
-        }
-
-        const termsOfServiceUrlElement = $('terms-of-service-url');
-        if (termsOfServiceUrlElement) {
-          setupLinkHandlers(
-              termsOfServiceUrlElement, FEEDBACK_TERM_OF_SERVICE_URL,
-              false /* useAppWindow */);
-        }
-
-        const bluetoothLogsInfoLinkElement = $('bluetooth-logs-info-link');
-        if (bluetoothLogsInfoLinkElement) {
-          bluetoothLogsInfoLinkElement.onclick = function(e) {
-            e.preventDefault();
-
-            chrome.app.window.create(
-                '/html/bluetooth_logs_info.html',
-                {width: 400, height: 120, resizable: false},
-                function(appWindow) {
-                  appWindow.contentWindow.onload = function() {
-                    i18nTemplate.process(
-                        appWindow.contentWindow.document, loadTimeData);
-                  };
-                });
-
-            bluetoothLogsInfoLinkElement.onauxclick = function(e) {
+        // The following URLs don't open on login screen, so hide them.
+        // TODO(crbug.com/1116383): Find a solution to display them properly.
+        if (feedbackInfo.flow != chrome.feedbackPrivate.FeedbackFlow.LOGIN) {
+          const legalHelpPageUrlElement = $('legal-help-page-url');
+          if (legalHelpPageUrlElement) {
+            setupLinkHandlers(
+                legalHelpPageUrlElement, FEEDBACK_LEGAL_HELP_URL,
+                false /* useAppWindow */);
+          }
+
+          const privacyPolicyUrlElement = $('privacy-policy-url');
+          if (privacyPolicyUrlElement) {
+            setupLinkHandlers(
+                privacyPolicyUrlElement, FEEDBACK_PRIVACY_POLICY_URL,
+                false /* useAppWindow */);
+          }
+
+          const termsOfServiceUrlElement = $('terms-of-service-url');
+          if (termsOfServiceUrlElement) {
+            setupLinkHandlers(
+                termsOfServiceUrlElement, FEEDBACK_TERM_OF_SERVICE_URL,
+                false /* useAppWindow */);
+          }
+
+          const bluetoothLogsInfoLinkElement = $('bluetooth-logs-info-link');
+          if (bluetoothLogsInfoLinkElement) {
+            bluetoothLogsInfoLinkElement.onclick = function(e) {
               e.preventDefault();
-            };
-          };
-        }
-
-        const assistantLogsInfoLinkElement = $('assistant-logs-info-link');
-        if (assistantLogsInfoLinkElement) {
-          assistantLogsInfoLinkElement.onclick = function(e) {
-            e.preventDefault();
 
-            chrome.app.window.create(
-                '/html/assistant_logs_info.html',
-                {width: 400, height: 120, resizable: false, frame: 'none'},
-                function(appWindow) {
-                  appWindow.contentWindow.onload = function() {
-                    i18nTemplate.process(
-                        appWindow.contentWindow.document, loadTimeData);
-                  };
-                });
+              chrome.app.window.create(
+                  '/html/bluetooth_logs_info.html',
+                  {width: 400, height: 120, resizable: false},
+                  function(appWindow) {
+                    appWindow.contentWindow.onload = function() {
+                      i18nTemplate.process(
+                          appWindow.contentWindow.document, loadTimeData);
+                    };
+                  });
+
+              bluetoothLogsInfoLinkElement.onauxclick = function(e) {
+                e.preventDefault();
+              };
+            };
+          }
 
-            assistantLogsInfoLinkElement.onauxclick = function(e) {
+          const assistantLogsInfoLinkElement = $('assistant-logs-info-link');
+          if (assistantLogsInfoLinkElement) {
+            assistantLogsInfoLinkElement.onclick = function(e) {
               e.preventDefault();
+
+              chrome.app.window.create(
+                  '/html/assistant_logs_info.html',
+                  {width: 400, height: 120, resizable: false, frame: 'none'},
+                  function(appWindow) {
+                    appWindow.contentWindow.onload = function() {
+                      i18nTemplate.process(
+                          appWindow.contentWindow.document, loadTimeData);
+                    };
+                  });
+
+              assistantLogsInfoLinkElement.onauxclick = function(e) {
+                e.preventDefault();
+              };
             };
-          };
+          }
         }
 
         // Make sure our focus starts on the description field.