Commit 8115efcf authored by Ehimare Okoyomon's avatar Ehimare Okoyomon Committed by Chromium LUCI CQ

[Android] Use filled keyboard accessory location

After speaking with UX for both teams, it was decided that it would be
best to only use one location icon for both page info / site settings
and keyboard accessory.

Change-Id: I74af67df53da05f358b8daa735d9bb5363c43982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566951Reviewed-by: default avatarFriedrich [CET] <fhorschig@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833270}
parent 9b0fdbae
...@@ -81,7 +81,7 @@ ...@@ -81,7 +81,7 @@
<issue <issue
id="VisibleForTests" id="VisibleForTests"
message="This method should only be accessed from tests or within private scope" message="This method should only be accessed from tests or within private scope"
errorLine1=" IconProvider.getIcon(context, R.drawable.ic_permission_location_outline)," errorLine1=" IconProvider.getIcon(context, R.drawable.ic_permission_location_filled),"
errorLine2=" ~~~~~~~"> errorLine2=" ~~~~~~~">
<location <location
file="../../chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/sheet_tabs/AddressAccessorySheetCoordinator.java" file="../../chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/sheet_tabs/AddressAccessorySheetCoordinator.java"
......
...@@ -36,7 +36,7 @@ public class AddressAccessorySheetCoordinator extends AccessorySheetTabCoordinat ...@@ -36,7 +36,7 @@ public class AddressAccessorySheetCoordinator extends AccessorySheetTabCoordinat
public AddressAccessorySheetCoordinator( public AddressAccessorySheetCoordinator(
Context context, @Nullable RecyclerView.OnScrollListener scrollListener) { Context context, @Nullable RecyclerView.OnScrollListener scrollListener) {
super(context.getString(R.string.address_accessory_sheet_title), super(context.getString(R.string.address_accessory_sheet_title),
IconProvider.getIcon(context, R.drawable.ic_permission_location_outline), IconProvider.getIcon(context, R.drawable.ic_permission_location_filled),
context.getString(R.string.address_accessory_sheet_toggle), context.getString(R.string.address_accessory_sheet_toggle),
context.getString(R.string.address_accessory_sheet_opened), context.getString(R.string.address_accessory_sheet_opened),
R.layout.address_accessory_sheet, AccessoryTabType.ADDRESSES, scrollListener); R.layout.address_accessory_sheet, AccessoryTabType.ADDRESSES, scrollListener);
......
...@@ -160,7 +160,6 @@ android_resources("java_resources") { ...@@ -160,7 +160,6 @@ android_resources("java_resources") {
"java/res/drawable/ic_offline_pin_24dp_on_dark_bg.xml", "java/res/drawable/ic_offline_pin_24dp_on_dark_bg.xml",
"java/res/drawable/ic_offline_pin_24dp_on_light_bg.xml", "java/res/drawable/ic_offline_pin_24dp_on_light_bg.xml",
"java/res/drawable/ic_permission_location_filled.xml", "java/res/drawable/ic_permission_location_filled.xml",
"java/res/drawable/ic_permission_location_outline.xml",
"java/res/drawable/ic_play_circle_filled_24dp_on_dark_bg.xml", "java/res/drawable/ic_play_circle_filled_24dp_on_dark_bg.xml",
"java/res/drawable/ic_play_circle_filled_24dp_on_light_bg.xml", "java/res/drawable/ic_play_circle_filled_24dp_on_light_bg.xml",
"java/res/drawable/ic_security_grey.xml", "java/res/drawable/ic_security_grey.xml",
......
<?xml version="1.0" encoding="utf-8"?>
<!--Copyright 2019 The Chromium Authors. All rights reserved. Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.-->
<vector xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools" tools:targetApi="21" android:width="24dp" android:height="24dp" android:viewportWidth="24.0" android:viewportHeight="24.0">
<path android:pathData="M12 2c3.87 0 7 3.13 7 7 0 5.25-7 13-7 13S5 14.25 5 9c0-3.87 3.13-7 7-7zm0 2C9.24 4 7 6.24 7 9c0 2.85 2.92 7.21 5 9.88 2.12-2.69 5-7 5-9.88 0-2.76-2.24-5-5-5zm0 2.5c1.38 0 2.5 1.12 2.5 2.5s-1.12 2.5-2.5 2.5S9.5 10.38 9.5 9s1.12-2.5 2.5-2.5z" android:strokeWidth="1" android:fillColor="#000000"/>
</vector>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment