Commit 812a5e69 authored by Darwin Huang's avatar Darwin Huang Committed by Commit Bot

Clipboard API: Simplify Encode*() function names.

The format used is already implied by the class name, so remove this
redundant information. Also, add some subclass comments for
consistency and clarity.

Refactoring change only. No functional changes intended.

Change-Id: I25e7d354e22a30ea164c9eab74d2d7f36e5a10e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405565
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: default avatarJarryd Goodman <jarrydg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#806244}
parent 9f778117
......@@ -46,14 +46,14 @@ class ClipboardImageReader final : public ClipboardReader {
}
worker_pool::PostTask(
FROM_HERE, CrossThreadBindOnce(
&ClipboardImageReader::EncodeImageOnBackgroundThread,
std::move(image), WrapCrossThreadPersistent(this),
std::move(clipboard_task_runner_)));
FROM_HERE,
CrossThreadBindOnce(&ClipboardImageReader::EncodeOnBackgroundThread,
std::move(image), WrapCrossThreadPersistent(this),
std::move(clipboard_task_runner_)));
}
private:
static void EncodeImageOnBackgroundThread(
static void EncodeOnBackgroundThread(
sk_sp<SkImage> image,
ClipboardImageReader* reader,
scoped_refptr<base::SingleThreadTaskRunner> clipboard_task_runner) {
......@@ -111,13 +111,13 @@ class ClipboardTextReader final : public ClipboardReader {
worker_pool::PostTask(
FROM_HERE, CrossThreadBindOnce(
&ClipboardTextReader::EncodeTextOnBackgroundThread,
&ClipboardTextReader::EncodeOnBackgroundThread,
std::move(plain_text), WrapCrossThreadPersistent(this),
std::move(clipboard_task_runner_)));
}
private:
static void EncodeTextOnBackgroundThread(
static void EncodeOnBackgroundThread(
String plain_text,
ClipboardTextReader* reader,
scoped_refptr<base::SingleThreadTaskRunner> clipboard_task_runner) {
......@@ -146,6 +146,7 @@ class ClipboardTextReader final : public ClipboardReader {
}
};
// Reads HTML from the System Clipboard as a blob with text/html content.
class ClipboardHtmlReader final : public ClipboardReader {
public:
explicit ClipboardHtmlReader(SystemClipboard* system_clipboard,
......@@ -182,14 +183,14 @@ class ClipboardHtmlReader final : public ClipboardReader {
}
worker_pool::PostTask(
FROM_HERE,
CrossThreadBindOnce(&ClipboardHtmlReader::EncodeHTMLOnBackgroundThread,
CrossThreadBindOnce(&ClipboardHtmlReader::EncodeOnBackgroundThread,
std::move(sanitized_html),
WrapCrossThreadPersistent(this),
std::move(clipboard_task_runner_)));
}
private:
static void EncodeHTMLOnBackgroundThread(
static void EncodeOnBackgroundThread(
String plain_text,
ClipboardHtmlReader* reader,
scoped_refptr<base::SingleThreadTaskRunner> clipboard_task_runner) {
......@@ -218,6 +219,7 @@ class ClipboardHtmlReader final : public ClipboardReader {
}
};
// Reads SVG from the System Clipboard as a blob with image/svg content.
class ClipboardSvgReader final : public ClipboardReader {
public:
ClipboardSvgReader(SystemClipboard* system_clipboard,
......@@ -258,13 +260,13 @@ class ClipboardSvgReader final : public ClipboardReader {
}
worker_pool::PostTask(
FROM_HERE,
CrossThreadBindOnce(&ClipboardSvgReader::EncodeSvgOnBackgroundThread,
CrossThreadBindOnce(&ClipboardSvgReader::EncodeOnBackgroundThread,
std::move(sanitized_svg),
WrapCrossThreadPersistent(this),
std::move(clipboard_task_runner_)));
}
static void EncodeSvgOnBackgroundThread(
static void EncodeOnBackgroundThread(
String plain_text,
ClipboardSvgReader* reader,
scoped_refptr<base::SingleThreadTaskRunner> clipboard_task_runner) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment