Commit 818c2008 authored by Abhishek Bhardwaj's avatar Abhishek Bhardwaj Committed by Commit Bot

DeviceScheduledUpdateChecker: Increase network wait timeout

This change increments the network wait timeout from 1 minute to 5
minutes. This is done because after manual testing it was found that it
could take up to just over a minute for shill to notify Chrome of a
network change. 5 minutes is used as the absolute worst case.

BUG=924762
TEST=Unit tests.

Change-Id: I60a412930f379fd7639d01e9c856c0443e8ef14a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757460
Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org>
Reviewed-by: default avatarSergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#691022}
parent c96d445d
...@@ -32,9 +32,10 @@ constexpr base::TimeDelta kOsAndPoliciesUpdateCheckerRetryTime = ...@@ -32,9 +32,10 @@ constexpr base::TimeDelta kOsAndPoliciesUpdateCheckerRetryTime =
// Time for which |OsAndPoliciesUpdateChecker| will wait for a valid network // Time for which |OsAndPoliciesUpdateChecker| will wait for a valid network
// before querying the update server for updates. After this time it will return // before querying the update server for updates. After this time it will return
// a failure. // a failure. During testing it was noted that on average 1 minute seemed to be
// the delay after which a network would be detected by Chrome.
constexpr base::TimeDelta kWaitForNetworkTimeout = constexpr base::TimeDelta kWaitForNetworkTimeout =
base::TimeDelta::FromMinutes(1); base::TimeDelta::FromMinutes(5);
} // namespace update_checker_internal } // namespace update_checker_internal
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment