Commit 81b72ef4 authored by David Jean's avatar David Jean Committed by Commit Bot

[ios] Remove "all passwords" button for manual fallback on <11.3

Bug: 908776
Change-Id: I14d17f328ae4ebbf158c03a9628c55f7a97f58e8
Reviewed-on: https://chromium-review.googlesource.com/c/1350928
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: default avatarJavier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611663}
parent b7153e7e
......@@ -235,7 +235,13 @@ BOOL AreCredentialsAtIndexesConnected(
}];
managePasswordsItem.accessibilityIdentifier =
manual_fill::ManagePasswordsAccessibilityIdentifier;
[self.consumer presentActions:@[ otherPasswordsItem, managePasswordsItem ]];
if (@available(iOS 11.3, *)) {
[self.consumer
presentActions:@[ otherPasswordsItem, managePasswordsItem ]];
} else {
// TODO(crbug.com/908776): fix or wait until iOS 11.2- is deprecated.
[self.consumer presentActions:@[ managePasswordsItem ]];
}
} else {
[self.consumer presentActions:@[]];
}
......
......@@ -340,6 +340,11 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is resumed after selecting other
// password.
- (void)testPasswordControllerResumes {
if (([UIDevice currentDevice].systemVersion.doubleValue < 11.3)) {
// TODO(crbug.com/908776): OtherPasswordsMatcher is disabled in <11.3.
return;
}
// For this test one password is needed.
SaveExamplePasswordForm();
......@@ -382,6 +387,11 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that the Password View Controller is resumed after dismissing "Other
// Passwords".
- (void)testPasswordControllerResumesWhenOtherPasswordsDismiss {
if (([UIDevice currentDevice].systemVersion.doubleValue < 11.3)) {
// TODO(crbug.com/908776): OtherPasswordsMatcher is disabled in <11.3.
return;
}
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......@@ -510,6 +520,11 @@ BOOL WaitForJavaScriptCondition(NSString* java_script_condition) {
// Tests that after switching fields the content size of the table view didn't
// grow.
- (void)testPasswordControllerKeepsRightSize {
if (([UIDevice currentDevice].systemVersion.doubleValue < 11.3)) {
// TODO(crbug.com/908776): OtherPasswordsMatcher is disabled in <11.3.
return;
}
// Bring up the keyboard.
[[EarlGrey selectElementWithMatcher:chrome_test_util::WebViewMatcher()]
performAction:chrome_test_util::TapWebElement(kFormElementUsername)];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment