Commit 81b9fb58 authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions] Enable captureVisibleTab tests for IPv6 URLs

https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a added support
for IPv6 patterns with URLPattern and activeTab, so we can now enable
the tests for captureVisibleTab using IPv6 URLs.

Bug: 839857
Change-Id: I29eec17b176c54a312cfdf5dc7d11c50b7b245f9
Reviewed-on: https://chromium-review.googlesource.com/1107243Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568842}
parent 71f313de
...@@ -333,10 +333,10 @@ TEST_F(ActiveTabTest, GrantToSinglePage) { ...@@ -333,10 +333,10 @@ TEST_F(ActiveTabTest, GrantToSinglePage) {
TEST_F(ActiveTabTest, CapturingPagesWithActiveTab) { TEST_F(ActiveTabTest, CapturingPagesWithActiveTab) {
std::vector<GURL> test_urls = { std::vector<GURL> test_urls = {
GURL("https://example.com"), GURL("chrome://version"), GURL("https://example.com"),
GURL("chrome://version"),
GURL("chrome://newtab"), GURL("chrome://newtab"),
// IPv6 addresses don't work with activeTab: https://crbug.com/853064. GURL("http://[2607:f8b0:4005:805::200e]"),
// {"http://[2607:f8b0:4005:805::200e]"},
extension->GetResourceURL("test.html"), extension->GetResourceURL("test.html"),
another_extension->GetResourceURL("test.html"), another_extension->GetResourceURL("test.html"),
}; };
......
...@@ -1120,9 +1120,8 @@ TEST_F(CaptureVisiblePageTest, URLsCapturableWithEitherActiveTabOrAllURLs) { ...@@ -1120,9 +1120,8 @@ TEST_F(CaptureVisiblePageTest, URLsCapturableWithEitherActiveTabOrAllURLs) {
// Normal web page. // Normal web page.
GURL("https://example.com"), GURL("https://example.com"),
// TODO(https://crbug.com/853064): IPv6 pages should behave like normal // IPv6 pages should behave like normal web pages.
// web pages. GURL("http://[2607:f8b0:4005:805::200e]"),
// GURL("http://[2607:f8b0:4005:805::200e]"),
// filesystem: urls with web origins should behave like normal web pages. // filesystem: urls with web origins should behave like normal web pages.
// TODO(https://crbug.com/853392): filesystem: URLs don't work with // TODO(https://crbug.com/853392): filesystem: URLs don't work with
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment