Commit 81bbeb6a authored by Ewann's avatar Ewann Committed by Commit Bot

Fixes DownloadManagerTestCase.testVisibleFileNameAndOpenInDownloads test.

-  Apple is hiding UIActivityViewController's contents from the host app on iPad.

Screenshot: https://drive.google.com/a/google.com/file/d/1yi2FH2gXPm4WNAg7kRLuzkYkHb5tAJE5/view?usp=sharing

Bug: 1044676
Change-Id: Ifc989ba6764fc2232c49333c128b1df953ad05a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019443Reviewed-by: default avatarEugene But <eugenebut@chromium.org>
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#735047}
parent fcb0eb6b
......@@ -253,8 +253,7 @@ bool WaitForOpenInDownloadsButton() {
}
// Tests that filename label and "Open in Downloads" button are showing.
// TODO(crbug.com/1044676): Fails on iPad iOS 13 simulator.
- (void)DISABLED_testVisibleFileNameAndOpenInDownloads {
- (void)testVisibleFileNameAndOpenInDownloads {
// Apple is hiding UIActivityViewController's contents from the host app on
// iOS 12. However, at least on iOS 13, the actions provided by the host app
// itself are not obfuscated.
......@@ -263,6 +262,11 @@ bool WaitForOpenInDownloadsButton() {
EARL_GREY_TEST_SKIPPED(@"Test skipped on iOS12.");
}
// Apple is hiding UIActivityViewController's contents from the host app on
// iPad.
if ([ChromeEarlGrey isIPadIdiom])
EARL_GREY_TEST_SKIPPED(@"Test skipped on iPad.");
// Earl Grey 1 can't test UI elements out of Chrome process.
#if defined(CHROME_EARL_GREY_1)
EARL_GREY_TEST_SKIPPED(@"Test skipped on Earl Grey 1.");
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment